content/renderer/pepper/pepper_plugin_instance_impl.cc - Issue 598453004: Replace some hard coded schemes with the constants in /url/url_constants.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/pepper_plugin_instance_impl.cc

Issue 598453004: Replace some hard coded schemes with the constants in /url/url_constants.h. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address the comment. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/pepper/pepper_plugin_instance_impl.cc

diff --git a/content/renderer/pepper/pepper_plugin_instance_impl.cc b/content/renderer/pepper/pepper_plugin_instance_impl.cc

index 98ca698ed56415c5ab34ced2dbebc7737345efd6..a74ddf143af237132d806ed4b826d4d932ab65cb 100644

--- a/content/renderer/pepper/pepper_plugin_instance_impl.cc

+++ b/content/renderer/pepper/pepper_plugin_instance_impl.cc

@@ -3213,7 +3213,7 @@ int32_t PepperPluginInstanceImpl::Navigate(

web_request.setHasUserGesture(from_user_action);

GURL gurl(web_request.url());

- if (gurl.SchemeIs("javascript")) {

+ if (gurl.SchemeIs(url::kJavaScriptScheme)) {

// In imitation of the NPAPI implementation, only |target_frame == frame| is

// allowed for security reasons.

WebFrame* target_frame =

« no previous file with comments | « content/renderer/npapi/webplugin_impl.cc ('k') | content/renderer/pepper/url_request_info_util.cc » ('j') | no next file with comments »