content/renderer/media/android/media_info_loader.cc - Issue 598453004: Replace some hard coded schemes with the constants in /url/url_constants.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/android/media_info_loader.cc

Issue 598453004: Replace some hard coded schemes with the constants in /url/url_constants.h. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address the comment. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/media/android/media_info_loader.cc

diff --git a/content/renderer/media/android/media_info_loader.cc b/content/renderer/media/android/media_info_loader.cc

index 95fed0b63a9a7e5a9c7c331f19476436c8996a26..35b79807b3a5c589feaaa3033a86e3d554978f68 100644

--- a/content/renderer/media/android/media_info_loader.cc

+++ b/content/renderer/media/android/media_info_loader.cc

@@ -126,7 +126,7 @@ void MediaInfoLoader::didReceiveResponse(

"Unknown")

<< " " << response.httpStatusCode();

DCHECK(active_loader_.get());

- if (!url_.SchemeIs("http") && !url_.SchemeIs("https")) {

+ if (!url_.SchemeIs(url::kHttpScheme) && !url_.SchemeIs(url::kHttpsScheme)) {

DidBecomeReady(kOk);

return;

}

« no previous file with comments | « content/child/web_url_loader_impl.cc ('k') | content/renderer/npapi/webplugin_impl.cc » ('j') | no next file with comments »