Replace some hard coded schemes with the constants in /url/url_constants.h.

content/shell/renderer/test_runner/web_test_proxy.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/shell/renderer/test_runner/web_test_proxy.h"
 
 #include <cctype>
 
 #include "base/callback_helpers.h"
 #include "base/command_line.h"
@@ skipping 131 matching lines @@
     delegate->PrintMessage("(null)");
     return;
   }
   delegate->PrintMessage(base::StringPrintf(
       "<NSURLResponse %s, http status code %d>",
       DescriptionSuitableForTestResult(response.url().spec()).c_str(),
       response.httpStatusCode()));
 }
 
 std::string URLDescription(const GURL& url) {
-  if (url.SchemeIs("file"))
+  if (url.SchemeIs(url::kFileScheme))
     return url.ExtractFileName();
   return url.possibly_invalid_spec();
 }
 
 std::string PriorityDescription(
     const blink::WebURLRequest::Priority& priority) {
   switch (priority) {
     case blink::WebURLRequest::PriorityVeryLow:
       return "VeryLow";
     case blink::WebURLRequest::PriorityLow:
@@ skipping 988 matching lines @@
   if (test_interfaces_->GetTestRunner()->httpHeadersToClear()) {
     const std::set<std::string>* clearHeaders =
         test_interfaces_->GetTestRunner()->httpHeadersToClear();
     for (std::set<std::string>::const_iterator header = clearHeaders->begin();
          header != clearHeaders->end();
          ++header)
       request.clearHTTPHeaderField(blink::WebString::fromUTF8(*header));
   }
 
   std::string host = url.host();
-  if (!host.empty() && (url.SchemeIs("http") || url.SchemeIs("https"))) {
+  if (!host.empty() && (url.SchemeIs(url::kHttpScheme) || url.SchemeIs(url::kHttpsScheme))) {

[Charlie Reis, 2014/09/23 23:20:18]

Style: Please wrap line at 80 chars (at the &&).

     if (!IsLocalHost(host) && !IsTestHost(host) &&
         !HostIsUsedBySomeTestsToGenerateError(host) &&
-        ((!main_document_url.SchemeIs("http") &&
-          !main_document_url.SchemeIs("https")) ||
+        ((!main_document_url.SchemeIs(url::kHttpScheme) &&
+          !main_document_url.SchemeIs(url::kHttpsScheme)) ||
          IsLocalHost(main_document_url.host())) &&
         !delegate_->AllowExternalPages()) {
       delegate_->PrintMessage(std::string("Blocked access to external URL ") +
                               request_url + "\n");
       BlockRequest(request);
       return;
     }
   }
 
   // Set the new substituted URL.
@@ skipping 177 matching lines @@
   if (!push_client_.get())
     push_client_.reset(new MockWebPushClient);
   return push_client_.get();
 }
 
 blink::WebPushClient* WebTestProxyBase::GetWebPushClient() {
   return GetPushClientMock();
 }
 
 }  // namespace content