content/child/npapi/plugin_url_fetcher.cc - Issue 598453004: Replace some hard coded schemes with the constants in /url/url_constants.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/npapi/plugin_url_fetcher.cc

Issue 598453004: Replace some hard coded schemes with the constants in /url/url_constants.h. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address the comment. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/child/npapi/plugin_url_fetcher.cc

diff --git a/content/child/npapi/plugin_url_fetcher.cc b/content/child/npapi/plugin_url_fetcher.cc

index 6a6fc100e7fee79673f7193f7d43a1527accec57..42617ab894123459a082a7de4b90f18c39b883d5 100644

--- a/content/child/npapi/plugin_url_fetcher.cc

+++ b/content/child/npapi/plugin_url_fetcher.cc

@@ -307,7 +307,7 @@ void PluginURLFetcher::OnReceivedResponse(const ResourceResponseInfo& info) {

// of the HTTP requests issued via NPN_GetURLNotify. Webkit and FF destroy

// the stream and invoke the NPP_DestroyStream function on the plugin if the

// HTTPrequest fails.

- if ((url_.SchemeIs("http") || url_.SchemeIs("https")) &&

+ if ((url_.SchemeIs(url::kHttpScheme) || url_.SchemeIs(url::kHttpsScheme)) &&

(response_code < 100 || response_code >= 400)) {

pending_failure_notification_ = true;

}

« no previous file with comments | « content/browser/loader/resource_scheduler.cc ('k') | content/child/site_isolation_policy.cc » ('j') | no next file with comments »