content/renderer/savable_resources.cc - Issue 598453004: Replace some hard coded schemes with the constants in /url/url_constants.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/savable_resources.cc

Issue 598453004: Replace some hard coded schemes with the constants in /url/url_constants.h. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address the comment. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/savable_resources.cc

diff --git a/content/renderer/savable_resources.cc b/content/renderer/savable_resources.cc

index 8ec18d76c241ded79392d42de7e127d567235fe4..958003f8783b7a8b321cd355b1255185a1f0eacf 100644

--- a/content/renderer/savable_resources.cc

+++ b/content/renderer/savable_resources.cc

@@ -90,7 +90,7 @@ void GetSavableResourceLinkForElement(

// Ignore those URLs which are not standard protocols. Because FTP

// protocol does no have cache mechanism, we will skip all

// sub-resources if they use FTP protocol.

- if (!u.SchemeIsHTTPOrHTTPS() && !u.SchemeIs("file"))

+ if (!u.SchemeIsHTTPOrHTTPS() && !u.SchemeIs(url::kFileScheme))

return;

// Ignore duplicated resource link.

if (!unique_check->resources_set->insert(u).second)

« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/shell/renderer/test_runner/web_test_proxy.cc » ('j') | no next file with comments »