Handle a few more instructions in assembler (cmov, cdq, cmpxchg, xadd, xchg).

Handle a few more instructions in assembler (cmov, cdq, cmpxchg, xadd, xchg).

BUG=none
R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=03532e59cec4d20a774b5aa3e51e5fc3ace1feab

[jvoung (off chromium), 2014-09-23 16:59:47]

jvoung@chromium.org changed reviewers:
+ stichnot@chromium.org

[Jim Stichnoth, 2014-09-23 17:21:21]

lgtm

https://codereview.chromium.org/597643002/diff/20001/src/assembler_ia32.cpp
File src/assembler_ia32.cpp (right):

https://codereview.chromium.org/597643002/diff/20001/src/assembler_ia32.cpp#n...
src/assembler_ia32.cpp:1688: if (Ty == IceType_i1 || Ty == IceType_i8)
After the dust settles, I think there are a lot of type checks like that that
should be factored out into helper functions.  Most of this is in
IceTargetLoweringX8632.cpp.

[jvoung (off chromium), 2014-09-23 20:20:56]

https://codereview.chromium.org/597643002/diff/20001/src/assembler_ia32.cpp
File src/assembler_ia32.cpp (right):

https://codereview.chromium.org/597643002/diff/20001/src/assembler_ia32.cpp#n...
src/assembler_ia32.cpp:1688: if (Ty == IceType_i1 || Ty == IceType_i8)
On 2014/09/23 17:21:20, stichnot wrote:
> After the dust settles, I think there are a lot of type checks like that that
> should be factored out into helper functions.  Most of this is in
> IceTargetLoweringX8632.cpp.

Acknowledged.


Yep -- Agreed. Technically there shouldn't be a cmpxchg w/ i1, since we don't
support atomics on i1 so I could remove that. Otherwise some of the other ops
will see i1 and need to use the byte form.

[jvoung (off chromium), 2014-09-23 20:32:29]

Committed patchset #2 (id:20001) manually as 03532e5 (presubmit successful).