Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Unified Diff: src/assembler_ia32.h

Issue 597643002: Handle a few more instructions in assembler (cmov, cdq, cmpxchg, xadd, xchg). (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: consistency Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/assembler_ia32.h
diff --git a/src/assembler_ia32.h b/src/assembler_ia32.h
index 810fab33e82e0d8e05a8e65690dd68731534e5ce..6192e91de9a7e55a1a66a6a4bd39f7d3713474cf 100644
--- a/src/assembler_ia32.h
+++ b/src/assembler_ia32.h
@@ -541,8 +541,6 @@ public:
void fincstp();
- void xchgl(GPRRegister dst, GPRRegister src);
-
void cmpl(GPRRegister reg, const Immediate &imm);
void cmpl(GPRRegister reg0, GPRRegister reg1);
void cmpl(GPRRegister reg, const Address &address);
@@ -582,6 +580,8 @@ public:
void subl(GPRRegister reg, const Address &address);
void subl(const Address &address, GPRRegister reg);
+ void cbw();
+ void cwd();
void cdq();
void idivl(GPRRegister reg);
@@ -645,11 +645,14 @@ public:
void jmp(const ConstantRelocatable *label);
void lock();
- void cmpxchgl(const Address &address, GPRRegister reg);
+ void cmpxchg(Type Ty, const Address &address, GPRRegister reg);
+ void cmpxchg8b(const Address &address);
+ void xadd(Type Ty, const Address &address, GPRRegister reg);
+ void xchg(Type Ty, const Address &address, GPRRegister reg);
- void LockCmpxchgl(const Address &address, GPRRegister reg) {
+ void LockCmpxchg(Type Ty, const Address &address, GPRRegister reg) {
lock();
- cmpxchgl(address, reg);
+ cmpxchg(Ty, address, reg);
}
intptr_t PreferredLoopAlignment() { return 16; }
« no previous file with comments | « src/IceTargetLoweringX8632.h ('k') | src/assembler_ia32.cpp » ('j') | src/assembler_ia32.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698