Issue 587223002: Emit source positions in deopt comments, too.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 587223002: Emit source positions in deopt comments, too. (Closed)

Created:
6 years, 3 months ago by Sven Panne

Modified:
6 years, 3 months ago

Reviewers:
Jarin

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -11 lines)			Patch
M	src/arm/lithium-codegen-arm.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/arm64/lithium-codegen-arm64.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/deoptimizer.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/hydrogen-instructions.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/lithium-codegen.cc	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/mips64/lithium-codegen-mips64.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/x87/lithium-codegen-x87.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Sven Panne

6 years, 3 months ago (2014-09-22 09:05:37 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 24109 (tree was closed).