Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Side by Side Diff: src/x64/lithium-codegen-x64.cc

Issue 587223002: Emit source positions in deopt comments, too. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips64/lithium-codegen-mips64.cc ('k') | src/x87/lithium-codegen-x87.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_X64 7 #if V8_TARGET_ARCH_X64
8 8
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 756 matching lines...) Expand 10 before | Expand all | Expand 10 after
767 767
768 if (info()->ShouldTrapOnDeopt()) { 768 if (info()->ShouldTrapOnDeopt()) {
769 Label done; 769 Label done;
770 if (cc != no_condition) { 770 if (cc != no_condition) {
771 __ j(NegateCondition(cc), &done, Label::kNear); 771 __ j(NegateCondition(cc), &done, Label::kNear);
772 } 772 }
773 __ int3(); 773 __ int3();
774 __ bind(&done); 774 __ bind(&done);
775 } 775 }
776 776
777 Deoptimizer::Reason reason(instr->Mnemonic(), detail); 777 Deoptimizer::Reason reason(instr->hydrogen_value()->position().raw(),
778 instr->Mnemonic(), detail);
778 DCHECK(info()->IsStub() || frame_is_built_); 779 DCHECK(info()->IsStub() || frame_is_built_);
779 // Go through jump table if we need to handle condition, build frame, or 780 // Go through jump table if we need to handle condition, build frame, or
780 // restore caller doubles. 781 // restore caller doubles.
781 if (cc == no_condition && frame_is_built_ && 782 if (cc == no_condition && frame_is_built_ &&
782 !info()->saves_caller_doubles()) { 783 !info()->saves_caller_doubles()) {
783 DeoptComment(reason); 784 DeoptComment(reason);
784 __ call(entry, RelocInfo::RUNTIME_ENTRY); 785 __ call(entry, RelocInfo::RUNTIME_ENTRY);
785 } else { 786 } else {
786 // We often have several deopts to the same entry, reuse the last 787 // We often have several deopts to the same entry, reuse the last
787 // jump entry if this is the case. 788 // jump entry if this is the case.
(...skipping 5096 matching lines...) Expand 10 before | Expand all | Expand 10 after
5884 CallRuntime(Runtime::kPushBlockContext, 2, instr); 5885 CallRuntime(Runtime::kPushBlockContext, 2, instr);
5885 RecordSafepoint(Safepoint::kNoLazyDeopt); 5886 RecordSafepoint(Safepoint::kNoLazyDeopt);
5886 } 5887 }
5887 5888
5888 5889
5889 #undef __ 5890 #undef __
5890 5891
5891 } } // namespace v8::internal 5892 } } // namespace v8::internal
5892 5893
5893 #endif // V8_TARGET_ARCH_X64 5894 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/mips64/lithium-codegen-mips64.cc ('k') | src/x87/lithium-codegen-x87.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698