Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Side by Side Diff: src/mips64/lithium-codegen-mips64.cc

Issue 587223002: Emit source positions in deopt comments, too. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/lithium-codegen-mips.cc ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/code-factory.h" 7 #include "src/code-factory.h"
8 #include "src/code-stubs.h" 8 #include "src/code-stubs.h"
9 #include "src/hydrogen-osr.h" 9 #include "src/hydrogen-osr.h"
10 #include "src/ic/ic.h" 10 #include "src/ic/ic.h"
(...skipping 792 matching lines...) Expand 10 before | Expand all | Expand 10 after
803 803
804 if (info()->ShouldTrapOnDeopt()) { 804 if (info()->ShouldTrapOnDeopt()) {
805 Label skip; 805 Label skip;
806 if (condition != al) { 806 if (condition != al) {
807 __ Branch(&skip, NegateCondition(condition), src1, src2); 807 __ Branch(&skip, NegateCondition(condition), src1, src2);
808 } 808 }
809 __ stop("trap_on_deopt"); 809 __ stop("trap_on_deopt");
810 __ bind(&skip); 810 __ bind(&skip);
811 } 811 }
812 812
813 Deoptimizer::Reason reason(instr->Mnemonic(), detail); 813 Deoptimizer::Reason reason(instr->hydrogen_value()->position().raw(),
814 instr->Mnemonic(), detail);
814 DCHECK(info()->IsStub() || frame_is_built_); 815 DCHECK(info()->IsStub() || frame_is_built_);
815 // Go through jump table if we need to handle condition, build frame, or 816 // Go through jump table if we need to handle condition, build frame, or
816 // restore caller doubles. 817 // restore caller doubles.
817 if (condition == al && frame_is_built_ && 818 if (condition == al && frame_is_built_ &&
818 !info()->saves_caller_doubles()) { 819 !info()->saves_caller_doubles()) {
819 DeoptComment(reason); 820 DeoptComment(reason);
820 __ Call(entry, RelocInfo::RUNTIME_ENTRY, condition, src1, src2); 821 __ Call(entry, RelocInfo::RUNTIME_ENTRY, condition, src1, src2);
821 } else { 822 } else {
822 // We often have several deopts to the same entry, reuse the last 823 // We often have several deopts to the same entry, reuse the last
823 // jump entry if this is the case. 824 // jump entry if this is the case.
(...skipping 5122 matching lines...) Expand 10 before | Expand all | Expand 10 after
5946 __ li(at, scope_info); 5947 __ li(at, scope_info);
5947 __ Push(at, ToRegister(instr->function())); 5948 __ Push(at, ToRegister(instr->function()));
5948 CallRuntime(Runtime::kPushBlockContext, 2, instr); 5949 CallRuntime(Runtime::kPushBlockContext, 2, instr);
5949 RecordSafepoint(Safepoint::kNoLazyDeopt); 5950 RecordSafepoint(Safepoint::kNoLazyDeopt);
5950 } 5951 }
5951 5952
5952 5953
5953 #undef __ 5954 #undef __
5954 5955
5955 } } // namespace v8::internal 5956 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/mips/lithium-codegen-mips.cc ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698