Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Side by Side Diff: src/x87/lithium-codegen-x87.cc

Issue 587223002: Emit source positions in deopt comments, too. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_X87 7 #if V8_TARGET_ARCH_X87
8 8
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 1130 matching lines...) Expand 10 before | Expand all | Expand 10 after
1141 __ bind(&done); 1141 __ bind(&done);
1142 } 1142 }
1143 1143
1144 if (info()->ShouldTrapOnDeopt()) { 1144 if (info()->ShouldTrapOnDeopt()) {
1145 Label done; 1145 Label done;
1146 if (cc != no_condition) __ j(NegateCondition(cc), &done, Label::kNear); 1146 if (cc != no_condition) __ j(NegateCondition(cc), &done, Label::kNear);
1147 __ int3(); 1147 __ int3();
1148 __ bind(&done); 1148 __ bind(&done);
1149 } 1149 }
1150 1150
1151 Deoptimizer::Reason reason(instr->Mnemonic(), detail); 1151 Deoptimizer::Reason reason(instr->hydrogen_value()->position().raw(),
1152 instr->Mnemonic(), detail);
1152 DCHECK(info()->IsStub() || frame_is_built_); 1153 DCHECK(info()->IsStub() || frame_is_built_);
1153 if (cc == no_condition && frame_is_built_) { 1154 if (cc == no_condition && frame_is_built_) {
1154 DeoptComment(reason); 1155 DeoptComment(reason);
1155 __ call(entry, RelocInfo::RUNTIME_ENTRY); 1156 __ call(entry, RelocInfo::RUNTIME_ENTRY);
1156 } else { 1157 } else {
1157 // We often have several deopts to the same entry, reuse the last 1158 // We often have several deopts to the same entry, reuse the last
1158 // jump entry if this is the case. 1159 // jump entry if this is the case.
1159 if (jump_table_.is_empty() || 1160 if (jump_table_.is_empty() ||
1160 jump_table_.last().address != entry || 1161 jump_table_.last().address != entry ||
1161 jump_table_.last().needs_frame != !frame_is_built_ || 1162 jump_table_.last().needs_frame != !frame_is_built_ ||
(...skipping 5090 matching lines...) Expand 10 before | Expand all | Expand 10 after
6252 CallRuntime(Runtime::kPushBlockContext, 2, instr); 6253 CallRuntime(Runtime::kPushBlockContext, 2, instr);
6253 RecordSafepoint(Safepoint::kNoLazyDeopt); 6254 RecordSafepoint(Safepoint::kNoLazyDeopt);
6254 } 6255 }
6255 6256
6256 6257
6257 #undef __ 6258 #undef __
6258 6259
6259 } } // namespace v8::internal 6260 } } // namespace v8::internal
6260 6261
6261 #endif // V8_TARGET_ARCH_X87 6262 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698