Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/ia32/lithium-codegen-ia32.cc

Issue 587223002: Emit source positions in deopt comments, too. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/hydrogen-instructions.h ('k') | src/lithium-codegen.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_IA32 7 #if V8_TARGET_ARCH_IA32
8 8
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 849 matching lines...) Expand 10 before | Expand all | Expand 10 after
860 __ popfd(); 860 __ popfd();
861 } 861 }
862 862
863 if (info()->ShouldTrapOnDeopt()) { 863 if (info()->ShouldTrapOnDeopt()) {
864 Label done; 864 Label done;
865 if (cc != no_condition) __ j(NegateCondition(cc), &done, Label::kNear); 865 if (cc != no_condition) __ j(NegateCondition(cc), &done, Label::kNear);
866 __ int3(); 866 __ int3();
867 __ bind(&done); 867 __ bind(&done);
868 } 868 }
869 869
870 Deoptimizer::Reason reason(instr->Mnemonic(), detail); 870 Deoptimizer::Reason reason(instr->hydrogen_value()->position().raw(),
871 instr->Mnemonic(), detail);
871 DCHECK(info()->IsStub() || frame_is_built_); 872 DCHECK(info()->IsStub() || frame_is_built_);
872 if (cc == no_condition && frame_is_built_) { 873 if (cc == no_condition && frame_is_built_) {
873 DeoptComment(reason); 874 DeoptComment(reason);
874 __ call(entry, RelocInfo::RUNTIME_ENTRY); 875 __ call(entry, RelocInfo::RUNTIME_ENTRY);
875 } else { 876 } else {
876 // We often have several deopts to the same entry, reuse the last 877 // We often have several deopts to the same entry, reuse the last
877 // jump entry if this is the case. 878 // jump entry if this is the case.
878 if (jump_table_.is_empty() || 879 if (jump_table_.is_empty() ||
879 jump_table_.last().address != entry || 880 jump_table_.last().address != entry ||
880 jump_table_.last().needs_frame != !frame_is_built_ || 881 jump_table_.last().needs_frame != !frame_is_built_ ||
(...skipping 4822 matching lines...) Expand 10 before | Expand all | Expand 10 after
5703 CallRuntime(Runtime::kPushBlockContext, 2, instr); 5704 CallRuntime(Runtime::kPushBlockContext, 2, instr);
5704 RecordSafepoint(Safepoint::kNoLazyDeopt); 5705 RecordSafepoint(Safepoint::kNoLazyDeopt);
5705 } 5706 }
5706 5707
5707 5708
5708 #undef __ 5709 #undef __
5709 5710
5710 } } // namespace v8::internal 5711 } } // namespace v8::internal
5711 5712
5712 #endif // V8_TARGET_ARCH_IA32 5713 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/hydrogen-instructions.h ('k') | src/lithium-codegen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698