Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: src/mips/lithium-codegen-mips.cc

Issue 587223002: Emit source positions in deopt comments, too. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/lithium-codegen.cc ('k') | src/mips64/lithium-codegen-mips64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved.7 1 // Copyright 2012 the V8 project authors. All rights reserved.7
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 842 matching lines...) Expand 10 before | Expand all | Expand 10 after
853 853
854 if (info()->ShouldTrapOnDeopt()) { 854 if (info()->ShouldTrapOnDeopt()) {
855 Label skip; 855 Label skip;
856 if (condition != al) { 856 if (condition != al) {
857 __ Branch(&skip, NegateCondition(condition), src1, src2); 857 __ Branch(&skip, NegateCondition(condition), src1, src2);
858 } 858 }
859 __ stop("trap_on_deopt"); 859 __ stop("trap_on_deopt");
860 __ bind(&skip); 860 __ bind(&skip);
861 } 861 }
862 862
863 Deoptimizer::Reason reason(instr->Mnemonic(), detail); 863 Deoptimizer::Reason reason(instr->hydrogen_value()->position().raw(),
864 instr->Mnemonic(), detail);
864 DCHECK(info()->IsStub() || frame_is_built_); 865 DCHECK(info()->IsStub() || frame_is_built_);
865 // Go through jump table if we need to handle condition, build frame, or 866 // Go through jump table if we need to handle condition, build frame, or
866 // restore caller doubles. 867 // restore caller doubles.
867 if (condition == al && frame_is_built_ && 868 if (condition == al && frame_is_built_ &&
868 !info()->saves_caller_doubles()) { 869 !info()->saves_caller_doubles()) {
869 DeoptComment(reason); 870 DeoptComment(reason);
870 __ Call(entry, RelocInfo::RUNTIME_ENTRY, condition, src1, src2); 871 __ Call(entry, RelocInfo::RUNTIME_ENTRY, condition, src1, src2);
871 } else { 872 } else {
872 // We often have several deopts to the same entry, reuse the last 873 // We often have several deopts to the same entry, reuse the last
873 // jump entry if this is the case. 874 // jump entry if this is the case.
(...skipping 5041 matching lines...) Expand 10 before | Expand all | Expand 10 after
5915 __ li(at, scope_info); 5916 __ li(at, scope_info);
5916 __ Push(at, ToRegister(instr->function())); 5917 __ Push(at, ToRegister(instr->function()));
5917 CallRuntime(Runtime::kPushBlockContext, 2, instr); 5918 CallRuntime(Runtime::kPushBlockContext, 2, instr);
5918 RecordSafepoint(Safepoint::kNoLazyDeopt); 5919 RecordSafepoint(Safepoint::kNoLazyDeopt);
5919 } 5920 }
5920 5921
5921 5922
5922 #undef __ 5923 #undef __
5923 5924
5924 } } // namespace v8::internal 5925 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/lithium-codegen.cc ('k') | src/mips64/lithium-codegen-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698