Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 578653005: Revert "Refactor ExtensionManifestTest to allow usage in src/extensions" (Closed)

Created:
6 years, 3 months ago by James Cook
Modified:
6 years, 3 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, vsevik, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, tfarina, yoshiki+watch_chromium.org, yurys, yuzo+watch_chromium.org, rginda+watch_chromium.org, paulirish+reviews_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert "Refactor ExtensionManifestTest to allow usage in src/extensions" This reverts commit bd1cc624f6fd9761409ee8a8ac5cfd3a5896c87a. Original CL: Refactor ExtensionManifestTest to allow usage in src/extensions https://codereview.chromium.org/572813002 Reason: Broke the official Win builders due to differences in how they report their version channel. http://master.chrome.corp.google.com:8011/builders/win%20trunk/builds/26150 BUG=414917 TEST=unit_tests TBR=rockot@chromium.org Committed: https://crrev.com/2bc038699947d1b05b15d35c5c5b3d4eac934f5d Cr-Commit-Position: refs/heads/master@{#295172}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+282 lines, -868 lines) Patch
M chrome/browser/extensions/api/streams_private/streams_private_manifest_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/commands/commands_manifest_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/api/extension_action/page_action_manifest_unittest.cc View 2 chunks +4 lines, -8 lines 0 comments Download
M chrome/common/extensions/api/file_browser_handlers/file_browser_handler_manifest_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/i18n/default_locale_manifest_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/identity/extension_manifests_auth_unittest.cc View 20 chunks +20 lines, -20 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/automation_unittest.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/content_scripts_manifest_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/exclude_matches_manifest_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
D chrome/common/extensions/manifest_tests/chrome_manifest_test.h View 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/common/extensions/manifest_tests/chrome_manifest_test.cc View 1 chunk +0 lines, -21 lines 0 comments Download
A + chrome/common/extensions/manifest_tests/extension_manifest_test.h View 6 chunks +36 lines, -31 lines 0 comments Download
A + chrome/common/extensions/manifest_tests/extension_manifest_test.cc View 12 chunks +81 lines, -57 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_about_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_chromepermission_unittest.cc View 3 chunks +5 lines, -8 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_contentsecuritypolicy_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_default_extent_path_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_devtools_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_dummy_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_experimental_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_homepage_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_icons_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_isolatedapp_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_kiosk_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_launch_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_launcher_page_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_manifest_version_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_offline_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_old_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_options_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_override_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_portsinpermissions_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_requirements_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_sandboxed_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_storage_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_ui_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_update_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_web_accessible_resources_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_web_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_webview_accessible_resources_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_unittest.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M chrome/common/extensions/permissions/settings_override_permission_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + chrome/test/data/extensions/manifest_tests/shared_module_export.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/extensions/manifest_tests/shared_module_export_and_import.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/extensions/manifest_tests/shared_module_export_foo.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/extensions/manifest_tests/shared_module_export_no_whitelist.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/extensions/manifest_tests/shared_module_export_not_dict.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/extensions/manifest_tests/shared_module_export_resource_not_string.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/extensions/manifest_tests/shared_module_export_resources_not_list.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/extensions/manifest_tests/shared_module_export_whitelist_item_not_id.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/extensions/manifest_tests/shared_module_export_whitelist_item_not_string.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/extensions/manifest_tests/shared_module_export_whitelist_not_list.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/extensions/manifest_tests/shared_module_import.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/extensions/manifest_tests/shared_module_import_invalid_id.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/extensions/manifest_tests/shared_module_import_invalid_version.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/extensions/manifest_tests/shared_module_import_not_list.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M extensions/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M extensions/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/manifest_handlers/externally_connectable_unittest.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M extensions/common/manifest_handlers/file_handler_manifest_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M extensions/common/manifest_handlers/shared_module_manifest_unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
D extensions/common/manifest_test.h View 1 chunk +0 lines, -160 lines 0 comments Download
D extensions/common/manifest_test.cc View 1 chunk +0 lines, -258 lines 0 comments Download
M extensions/common/test_util.h View 2 chunks +11 lines, -0 lines 0 comments Download
M extensions/common/test_util.cc View 2 chunks +19 lines, -0 lines 0 comments Download
M extensions/extensions.gyp View 2 chunks +0 lines, -3 lines 0 comments Download
D extensions/test/data/manifest_tests/shared_module_export.json View 1 chunk +0 lines, -15 lines 0 comments Download
D extensions/test/data/manifest_tests/shared_module_export_and_import.json View 1 chunk +0 lines, -14 lines 0 comments Download
D extensions/test/data/manifest_tests/shared_module_export_foo.json View 1 chunk +0 lines, -11 lines 0 comments Download
D extensions/test/data/manifest_tests/shared_module_export_no_whitelist.json View 1 chunk +0 lines, -11 lines 0 comments Download
D extensions/test/data/manifest_tests/shared_module_export_not_dict.json View 1 chunk +0 lines, -9 lines 0 comments Download
D extensions/test/data/manifest_tests/shared_module_export_resource_not_string.json View 1 chunk +0 lines, -12 lines 0 comments Download
D extensions/test/data/manifest_tests/shared_module_export_resources_not_list.json View 1 chunk +0 lines, -9 lines 0 comments Download
D extensions/test/data/manifest_tests/shared_module_export_whitelist_item_not_id.json View 1 chunk +0 lines, -14 lines 0 comments Download
D extensions/test/data/manifest_tests/shared_module_export_whitelist_item_not_string.json View 1 chunk +0 lines, -17 lines 0 comments Download
D extensions/test/data/manifest_tests/shared_module_export_whitelist_not_list.json View 1 chunk +0 lines, -12 lines 0 comments Download
D extensions/test/data/manifest_tests/shared_module_import.json View 1 chunk +0 lines, -14 lines 0 comments Download
D extensions/test/data/manifest_tests/shared_module_import_invalid_id.json View 1 chunk +0 lines, -10 lines 0 comments Download
D extensions/test/data/manifest_tests/shared_module_import_invalid_version.json View 1 chunk +0 lines, -11 lines 0 comments Download
D extensions/test/data/manifest_tests/shared_module_import_not_list.json View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
James Cook
Committed patchset #1 (id:1) manually as 2bc0386.
6 years, 3 months ago (2014-09-16 23:12:15 UTC) #1
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 23:12:16 UTC) #2
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2bc038699947d1b05b15d35c5c5b3d4eac934f5d
Cr-Commit-Position: refs/heads/master@{#295172}

Powered by Google App Engine
This is Rietveld 408576698