Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: chrome/common/extensions/manifest_tests/extension_manifests_webview_accessible_resources_unittest.cc

Issue 578653005: Revert "Refactor ExtensionManifestTest to allow usage in src/extensions" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/strings/string_number_conversions.h" 5 #include "base/strings/string_number_conversions.h"
6 #include "chrome/common/extensions/manifest_tests/chrome_manifest_test.h" 6 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
7 #include "extensions/common/error_utils.h" 7 #include "extensions/common/error_utils.h"
8 #include "extensions/common/manifest_constants.h" 8 #include "extensions/common/manifest_constants.h"
9 #include "extensions/common/manifest_handlers/webview_info.h" 9 #include "extensions/common/manifest_handlers/webview_info.h"
10 10
11 using extensions::ErrorUtils; 11 using extensions::ErrorUtils;
12 using extensions::Extension; 12 using extensions::Extension;
13 using extensions::WebviewInfo; 13 using extensions::WebviewInfo;
14 namespace errors = extensions::manifest_errors; 14 namespace errors = extensions::manifest_errors;
15 15
16 class WebviewAccessibleResourcesManifestTest : public ChromeManifestTest { 16 class WebviewAccessibleResourcesManifestTest : public ExtensionManifestTest {
17 }; 17 };
18 18
19 TEST_F(WebviewAccessibleResourcesManifestTest, WebviewAccessibleResources) { 19 TEST_F(WebviewAccessibleResourcesManifestTest, WebviewAccessibleResources) {
20 // Manifest version 2 with webview accessible resources specified. 20 // Manifest version 2 with webview accessible resources specified.
21 scoped_refptr<Extension> extension1( 21 scoped_refptr<Extension> extension1(
22 LoadAndExpectSuccess("webview_accessible_resources_1.json")); 22 LoadAndExpectSuccess("webview_accessible_resources_1.json"));
23 23
24 EXPECT_FALSE( 24 EXPECT_FALSE(
25 WebviewInfo::IsResourceWebviewAccessible(extension1.get(), 25 WebviewInfo::IsResourceWebviewAccessible(extension1.get(),
26 "fail", 26 "fail",
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 LoadAndExpectError("webview_accessible_resources_invalid5.json", 103 LoadAndExpectError("webview_accessible_resources_invalid5.json",
104 errors::kInvalidWebviewPartitionName); 104 errors::kInvalidWebviewPartitionName);
105 LoadAndExpectError("webview_accessible_resources_invalid6.json", 105 LoadAndExpectError("webview_accessible_resources_invalid6.json",
106 errors::kInvalidWebviewAccessibleResourcesList); 106 errors::kInvalidWebviewAccessibleResourcesList);
107 LoadAndExpectError("webview_accessible_resources_invalid7.json", 107 LoadAndExpectError("webview_accessible_resources_invalid7.json",
108 errors::kInvalidWebviewAccessibleResourcesList); 108 errors::kInvalidWebviewAccessibleResourcesList);
109 LoadAndExpectError("webview_accessible_resources_invalid8.json", 109 LoadAndExpectError("webview_accessible_resources_invalid8.json",
110 ErrorUtils::FormatErrorMessage( 110 ErrorUtils::FormatErrorMessage(
111 errors::kInvalidWebviewAccessibleResource, base::IntToString(0))); 111 errors::kInvalidWebviewAccessibleResource, base::IntToString(0)));
112 } 112 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698