Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: extensions/common/manifest_handlers/shared_module_manifest_unittest.cc

Issue 578653005: Revert "Refactor ExtensionManifestTest to allow usage in src/extensions" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/version.h" 5 #include "base/version.h"
6 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
6 #include "extensions/common/extension.h" 7 #include "extensions/common/extension.h"
7 #include "extensions/common/manifest_handlers/shared_module_info.h" 8 #include "extensions/common/manifest_handlers/shared_module_info.h"
8 #include "extensions/common/manifest_test.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
11 namespace { 11 namespace {
12 12
13 const char* kValidImportPath = 13 const char* kValidImportPath =
14 "_modules/abcdefghijklmnopabcdefghijklmnop/foo/bar.html"; 14 "_modules/abcdefghijklmnopabcdefghijklmnop/foo/bar.html";
15 const char* kValidImportPathID = "abcdefghijklmnopabcdefghijklmnop"; 15 const char* kValidImportPathID = "abcdefghijklmnopabcdefghijklmnop";
16 const char* kValidImportPathRelative = "foo/bar.html"; 16 const char* kValidImportPathRelative = "foo/bar.html";
17 const char* kInvalidImportPath = "_modules/abc/foo.html"; 17 const char* kInvalidImportPath = "_modules/abc/foo.html";
18 const char* kImportId1 = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"; 18 const char* kImportId1 = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";
19 const char* kImportId2 = "bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb"; 19 const char* kImportId2 = "bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb";
20 const char* kNoImport = "cccccccccccccccccccccccccccccccc"; 20 const char* kNoImport = "cccccccccccccccccccccccccccccccc";
21 21
22 } // namespace 22 } // namespace
23 23
24 namespace extensions { 24 namespace extensions {
25 25
26 class SharedModuleManifestTest : public ManifestTest { 26 class SharedModuleManifestTest : public ExtensionManifestTest {
27 }; 27 };
28 28
29 TEST_F(SharedModuleManifestTest, ExportsAll) { 29 TEST_F(SharedModuleManifestTest, ExportsAll) {
30 ManifestData manifest("shared_module_export.json"); 30 Manifest manifest("shared_module_export.json");
31 31
32 scoped_refptr<Extension> extension = LoadAndExpectSuccess(manifest); 32 scoped_refptr<Extension> extension = LoadAndExpectSuccess(manifest);
33 33
34 EXPECT_TRUE(SharedModuleInfo::IsSharedModule(extension.get())) 34 EXPECT_TRUE(SharedModuleInfo::IsSharedModule(extension.get()))
35 << manifest.name(); 35 << manifest.name();
36 EXPECT_FALSE(SharedModuleInfo::ImportsModules(extension.get())) 36 EXPECT_FALSE(SharedModuleInfo::ImportsModules(extension.get()))
37 << manifest.name(); 37 << manifest.name();
38 EXPECT_TRUE(SharedModuleInfo::IsExportAllowed(extension.get(), "foo")) 38 EXPECT_TRUE(SharedModuleInfo::IsExportAllowed(extension.get(), "foo"))
39 << manifest.name(); 39 << manifest.name();
40 EXPECT_TRUE(SharedModuleInfo::IsExportAllowed(extension.get(), "foo/bar")) 40 EXPECT_TRUE(SharedModuleInfo::IsExportAllowed(extension.get(), "foo/bar"))
41 << manifest.name(); 41 << manifest.name();
42 42
43 EXPECT_TRUE(SharedModuleInfo::IsExportAllowedByWhitelist(extension.get(), 43 EXPECT_TRUE(SharedModuleInfo::IsExportAllowedByWhitelist(extension.get(),
44 kImportId1)) << manifest.name(); 44 kImportId1)) << manifest.name();
45 EXPECT_TRUE(SharedModuleInfo::IsExportAllowedByWhitelist(extension.get(), 45 EXPECT_TRUE(SharedModuleInfo::IsExportAllowedByWhitelist(extension.get(),
46 kImportId2)) << manifest.name(); 46 kImportId2)) << manifest.name();
47 EXPECT_FALSE(SharedModuleInfo::IsExportAllowedByWhitelist(extension.get(), 47 EXPECT_FALSE(SharedModuleInfo::IsExportAllowedByWhitelist(extension.get(),
48 kNoImport)) << manifest.name(); 48 kNoImport)) << manifest.name();
49 } 49 }
50 50
51 TEST_F(SharedModuleManifestTest, ExportWhitelistAll) { 51 TEST_F(SharedModuleManifestTest, ExportWhitelistAll) {
52 ManifestData manifest("shared_module_export_no_whitelist.json"); 52 Manifest manifest("shared_module_export_no_whitelist.json");
53 53
54 scoped_refptr<Extension> extension = LoadAndExpectSuccess(manifest); 54 scoped_refptr<Extension> extension = LoadAndExpectSuccess(manifest);
55 55
56 EXPECT_TRUE(SharedModuleInfo::IsExportAllowedByWhitelist(extension.get(), 56 EXPECT_TRUE(SharedModuleInfo::IsExportAllowedByWhitelist(extension.get(),
57 kImportId1)) << manifest.name(); 57 kImportId1)) << manifest.name();
58 EXPECT_TRUE(SharedModuleInfo::IsExportAllowedByWhitelist(extension.get(), 58 EXPECT_TRUE(SharedModuleInfo::IsExportAllowedByWhitelist(extension.get(),
59 kImportId2)) << manifest.name(); 59 kImportId2)) << manifest.name();
60 EXPECT_TRUE(SharedModuleInfo::IsExportAllowedByWhitelist(extension.get(), 60 EXPECT_TRUE(SharedModuleInfo::IsExportAllowedByWhitelist(extension.get(),
61 kNoImport)) << manifest.name(); 61 kNoImport)) << manifest.name();
62 } 62 }
63 63
64 TEST_F(SharedModuleManifestTest, ExportFoo) { 64 TEST_F(SharedModuleManifestTest, ExportFoo) {
65 ManifestData manifest("shared_module_export_foo.json"); 65 Manifest manifest("shared_module_export_foo.json");
66 66
67 scoped_refptr<Extension> extension = LoadAndExpectSuccess(manifest); 67 scoped_refptr<Extension> extension = LoadAndExpectSuccess(manifest);
68 68
69 EXPECT_TRUE(SharedModuleInfo::IsSharedModule(extension.get())) 69 EXPECT_TRUE(SharedModuleInfo::IsSharedModule(extension.get()))
70 << manifest.name(); 70 << manifest.name();
71 EXPECT_FALSE(SharedModuleInfo::ImportsModules(extension.get())) 71 EXPECT_FALSE(SharedModuleInfo::ImportsModules(extension.get()))
72 << manifest.name(); 72 << manifest.name();
73 EXPECT_TRUE(SharedModuleInfo::IsExportAllowed(extension.get(), "foo")) 73 EXPECT_TRUE(SharedModuleInfo::IsExportAllowed(extension.get(), "foo"))
74 << manifest.name(); 74 << manifest.name();
75 EXPECT_FALSE(SharedModuleInfo::IsExportAllowed(extension.get(), "foo/bar")) 75 EXPECT_FALSE(SharedModuleInfo::IsExportAllowed(extension.get(), "foo/bar"))
(...skipping 25 matching lines...) Expand all
101 EXPECT_FALSE(SharedModuleInfo::IsImportedPath(kInvalidImportPath)); 101 EXPECT_FALSE(SharedModuleInfo::IsImportedPath(kInvalidImportPath));
102 102
103 std::string id; 103 std::string id;
104 std::string relative; 104 std::string relative;
105 SharedModuleInfo::ParseImportedPath(kValidImportPath, &id, &relative); 105 SharedModuleInfo::ParseImportedPath(kValidImportPath, &id, &relative);
106 EXPECT_EQ(id, kValidImportPathID); 106 EXPECT_EQ(id, kValidImportPathID);
107 EXPECT_EQ(relative, kValidImportPathRelative); 107 EXPECT_EQ(relative, kValidImportPathRelative);
108 } 108 }
109 109
110 TEST_F(SharedModuleManifestTest, Import) { 110 TEST_F(SharedModuleManifestTest, Import) {
111 ManifestData manifest("shared_module_import.json"); 111 Manifest manifest("shared_module_import.json");
112 112
113 scoped_refptr<Extension> extension = LoadAndExpectSuccess(manifest); 113 scoped_refptr<Extension> extension = LoadAndExpectSuccess(manifest);
114 114
115 EXPECT_FALSE(SharedModuleInfo::IsSharedModule(extension.get())) 115 EXPECT_FALSE(SharedModuleInfo::IsSharedModule(extension.get()))
116 << manifest.name(); 116 << manifest.name();
117 EXPECT_TRUE(SharedModuleInfo::ImportsModules(extension.get())) 117 EXPECT_TRUE(SharedModuleInfo::ImportsModules(extension.get()))
118 << manifest.name(); 118 << manifest.name();
119 const std::vector<SharedModuleInfo::ImportInfo>& imports = 119 const std::vector<SharedModuleInfo::ImportInfo>& imports =
120 SharedModuleInfo::GetImports(extension.get()); 120 SharedModuleInfo::GetImports(extension.get());
121 ASSERT_EQ(2U, imports.size()); 121 ASSERT_EQ(2U, imports.size());
(...skipping 15 matching lines...) Expand all
137 "Invalid value for 'import'."), 137 "Invalid value for 'import'."),
138 Testcase("shared_module_import_invalid_id.json", 138 Testcase("shared_module_import_invalid_id.json",
139 "Invalid value for 'import[0].id'."), 139 "Invalid value for 'import[0].id'."),
140 Testcase("shared_module_import_invalid_version.json", 140 Testcase("shared_module_import_invalid_version.json",
141 "Invalid value for 'import[0].minimum_version'."), 141 "Invalid value for 'import[0].minimum_version'."),
142 }; 142 };
143 RunTestcases(testcases, arraysize(testcases), EXPECT_TYPE_ERROR); 143 RunTestcases(testcases, arraysize(testcases), EXPECT_TYPE_ERROR);
144 } 144 }
145 145
146 } // namespace extensions 146 } // namespace extensions
OLDNEW
« no previous file with comments | « extensions/common/manifest_handlers/file_handler_manifest_unittest.cc ('k') | extensions/common/manifest_test.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698