OLD | NEW |
1 // Copyright 2014 The Chromium Authors. All rights reserved. | 1 // Copyright 2014 The Chromium Authors. All rights reserved. |
2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
4 | 4 |
5 #include <algorithm> | 5 #include <algorithm> |
6 | 6 |
7 #include "chrome/common/extensions/manifest_tests/chrome_manifest_test.h" | 7 #include "chrome/common/extensions/features/feature_channel.h" |
| 8 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h" |
8 #include "extensions/common/error_utils.h" | 9 #include "extensions/common/error_utils.h" |
9 #include "extensions/common/manifest_constants.h" | 10 #include "extensions/common/manifest_constants.h" |
10 #include "extensions/common/manifest_handlers/externally_connectable.h" | 11 #include "extensions/common/manifest_handlers/externally_connectable.h" |
11 #include "extensions/common/permissions/permissions_data.h" | 12 #include "extensions/common/permissions/permissions_data.h" |
12 #include "testing/gmock/include/gmock/gmock.h" | 13 #include "testing/gmock/include/gmock/gmock.h" |
13 #include "testing/gtest/include/gtest/gtest.h" | 14 #include "testing/gtest/include/gtest/gtest.h" |
14 | 15 |
15 using testing::ElementsAre; | 16 using testing::ElementsAre; |
16 | 17 |
17 namespace extensions { | 18 namespace extensions { |
18 | 19 |
19 namespace errors = externally_connectable_errors; | 20 namespace errors = externally_connectable_errors; |
20 | 21 |
21 // TODO(jamescook): Convert from ChromeManifestTest to ManifestTest. | 22 class ExternallyConnectableTest : public ExtensionManifestTest { |
22 class ExternallyConnectableTest : public ChromeManifestTest { | |
23 public: | 23 public: |
24 ExternallyConnectableTest() {} | 24 ExternallyConnectableTest() : channel_(chrome::VersionInfo::CHANNEL_DEV) {} |
25 virtual ~ExternallyConnectableTest() {} | |
26 | 25 |
27 protected: | 26 protected: |
28 ExternallyConnectableInfo* GetExternallyConnectableInfo( | 27 ExternallyConnectableInfo* GetExternallyConnectableInfo( |
29 scoped_refptr<Extension> extension) { | 28 scoped_refptr<Extension> extension) { |
30 return static_cast<ExternallyConnectableInfo*>( | 29 return static_cast<ExternallyConnectableInfo*>( |
31 extension->GetManifestData(manifest_keys::kExternallyConnectable)); | 30 extension->GetManifestData(manifest_keys::kExternallyConnectable)); |
32 } | 31 } |
| 32 |
| 33 private: |
| 34 ScopedCurrentChannel channel_; |
33 }; | 35 }; |
34 | 36 |
35 TEST_F(ExternallyConnectableTest, IDsAndMatches) { | 37 TEST_F(ExternallyConnectableTest, IDsAndMatches) { |
36 scoped_refptr<Extension> extension = | 38 scoped_refptr<Extension> extension = |
37 LoadAndExpectSuccess("externally_connectable_ids_and_matches.json"); | 39 LoadAndExpectSuccess("externally_connectable_ids_and_matches.json"); |
38 ASSERT_TRUE(extension.get()); | 40 ASSERT_TRUE(extension.get()); |
39 | 41 |
40 EXPECT_TRUE(extension->permissions_data()->HasAPIPermission( | 42 EXPECT_TRUE(extension->permissions_data()->HasAPIPermission( |
41 APIPermission::kWebConnectable)); | 43 APIPermission::kWebConnectable)); |
42 | 44 |
(...skipping 267 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
310 EXPECT_TRUE(info->matches.MatchesURL(GURL("https://example.com"))); | 312 EXPECT_TRUE(info->matches.MatchesURL(GURL("https://example.com"))); |
311 EXPECT_TRUE(info->matches.MatchesURL(GURL("http://build.chromium.org"))); | 313 EXPECT_TRUE(info->matches.MatchesURL(GURL("http://build.chromium.org"))); |
312 } | 314 } |
313 | 315 |
314 TEST_F(ExternallyConnectableTest, WarningNothingSpecified) { | 316 TEST_F(ExternallyConnectableTest, WarningNothingSpecified) { |
315 LoadAndExpectWarning("externally_connectable_nothing_specified.json", | 317 LoadAndExpectWarning("externally_connectable_nothing_specified.json", |
316 errors::kErrorNothingSpecified); | 318 errors::kErrorNothingSpecified); |
317 } | 319 } |
318 | 320 |
319 } // namespace extensions | 321 } // namespace extensions |
OLD | NEW |