Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: extensions/common/test_util.cc

Issue 578653005: Revert "Refactor ExtensionManifestTest to allow usage in src/extensions" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « extensions/common/test_util.h ('k') | extensions/extensions.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/common/test_util.h" 5 #include "extensions/common/test_util.h"
6 6
7 #include "base/json/json_reader.h"
8 #include "base/values.h"
7 #include "extensions/common/extension.h" 9 #include "extensions/common/extension.h"
8 #include "extensions/common/extension_builder.h" 10 #include "extensions/common/extension_builder.h"
9 #include "extensions/common/value_builder.h" 11 #include "extensions/common/value_builder.h"
12 #include "testing/gtest/include/gtest/gtest.h"
10 13
11 namespace extensions { 14 namespace extensions {
12 namespace test_util { 15 namespace test_util {
13 16
14 ExtensionBuilder& BuildExtension(ExtensionBuilder& builder) { 17 ExtensionBuilder& BuildExtension(ExtensionBuilder& builder) {
15 return builder 18 return builder
16 .SetManifest(DictionaryBuilder() 19 .SetManifest(DictionaryBuilder()
17 .Set("name", "Test extension") 20 .Set("name", "Test extension")
18 .Set("version", "1.0") 21 .Set("version", "1.0")
19 .Set("manifest_version", 2)); 22 .Set("manifest_version", 2));
20 } 23 }
21 24
22 scoped_refptr<Extension> CreateEmptyExtension() { 25 scoped_refptr<Extension> CreateEmptyExtension() {
23 scoped_refptr<Extension> empty_extension( 26 scoped_refptr<Extension> empty_extension(
24 ExtensionBuilder() 27 ExtensionBuilder()
25 .SetManifest( 28 .SetManifest(
26 DictionaryBuilder().Set("name", "Test").Set("version", "1.0")) 29 DictionaryBuilder().Set("name", "Test").Set("version", "1.0"))
27 .Build()); 30 .Build());
28 return empty_extension; 31 return empty_extension;
29 } 32 }
30 33
31 scoped_refptr<Extension> CreateExtensionWithID(const std::string& id) { 34 scoped_refptr<Extension> CreateExtensionWithID(const std::string& id) {
32 return ExtensionBuilder() 35 return ExtensionBuilder()
33 .SetManifest( 36 .SetManifest(
34 DictionaryBuilder().Set("name", "test").Set("version", "0.1")) 37 DictionaryBuilder().Set("name", "test").Set("version", "0.1"))
35 .SetID(id) 38 .SetID(id)
36 .Build(); 39 .Build();
37 } 40 }
38 41
42 scoped_ptr<base::DictionaryValue> ParseJsonDictionaryWithSingleQuotes(
43 std::string json) {
44 std::replace(json.begin(), json.end(), '\'', '"');
45 std::string error_msg;
46 scoped_ptr<base::Value> result(base::JSONReader::ReadAndReturnError(
47 json, base::JSON_ALLOW_TRAILING_COMMAS, NULL, &error_msg));
48 scoped_ptr<base::DictionaryValue> result_dict;
49 if (result && result->IsType(base::Value::TYPE_DICTIONARY)) {
50 result_dict.reset(static_cast<base::DictionaryValue*>(result.release()));
51 } else {
52 ADD_FAILURE() << "Failed to parse \"" << json << "\": " << error_msg;
53 result_dict.reset(new base::DictionaryValue());
54 }
55 return result_dict.Pass();
56 }
57
39 } // namespace test_util 58 } // namespace test_util
40 } // namespace extensions 59 } // namespace extensions
OLDNEW
« no previous file with comments | « extensions/common/test_util.h ('k') | extensions/extensions.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698