chrome/common/extensions/manifest_tests/extension_manifests_old_unittest.cc - Issue 578653005: Revert "Refactor ExtensionManifestTest to allow usage in src/extensions"

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/manifest_tests/extension_manifests_old_unittest.cc

Issue 578653005: Revert "Refactor ExtensionManifestTest to allow usage in src/extensions" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/common/extensions/manifest_tests/extension_manifests_offline_unittest.cc ('k') | chrome/common/extensions/manifest_tests/extension_manifests_options_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/common/extensions/manifest_tests/chrome_manifest_test.h"	5 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"

6	6

7 #include "extensions/common/extension.h"	7 #include "extensions/common/extension.h"

8 #include "extensions/common/permissions/permissions_data.h"	8 #include "extensions/common/permissions/permissions_data.h"

9 #include "testing/gtest/include/gtest/gtest.h"	9 #include "testing/gtest/include/gtest/gtest.h"

10	10

11 // Tests that the old permission name "unlimited_storage" still works for	11 // Tests that the old permission name "unlimited_storage" still works for

12 // backwards compatibility (we renamed it to "unlimitedStorage").	12 // backwards compatibility (we renamed it to "unlimitedStorage").

13 TEST_F(ChromeManifestTest, OldUnlimitedStoragePermission) {	13 TEST_F(ExtensionManifestTest, OldUnlimitedStoragePermission) {

14 scoped_refptr<extensions::Extension> extension = LoadAndExpectSuccess(	14 scoped_refptr<extensions::Extension> extension = LoadAndExpectSuccess(

15 "old_unlimited_storage.json", extensions::Manifest::INTERNAL,	15 "old_unlimited_storage.json", extensions::Manifest::INTERNAL,

16 extensions::Extension::NO_FLAGS);	16 extensions::Extension::NO_FLAGS);

17 EXPECT_TRUE(extension->permissions_data()->HasAPIPermission(	17 EXPECT_TRUE(extension->permissions_data()->HasAPIPermission(

18 extensions::APIPermission::kUnlimitedStorage));	18 extensions::APIPermission::kUnlimitedStorage));

19 }	19 }

OLD	NEW