Move the user agent styles sheets to blink_resources.grd (Part 3)

Reland Move the user agent styles sheets to blink_resources.grd (Part 3)

Blink should make use of blink_resources.grd for the inline resources of user agent stylesheets.
This removes the dependency upon using make-file-arrays.py which embeds these resources as strings. 

Also the .rodata section of libblink_web (in component build mode) is reduced by ~33kb.

Part 1: https://codereview.chromium.org/436843004/
Part 2: https://codereview.chromium.org/422023008

The chromium dependent patches [1] and [2] have already landed.

[1] https://codereview.chromium.org/818563003
[2] https://codereview.chromium.org/819573002

BUG=312586
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188383

[vivekg, 2014-09-14 00:19:08]

vivekg@chromium.org changed reviewers:
+ abarth@chromium.org, eseidel@chromium.org

[vivekg, 2014-09-14 00:19:22]

vivekg@chromium.org changed reviewers:
+ vivekg@chromium.org

[vivekg, 2014-09-14 00:19:23]

PTAL, thank you.

[vivekg, 2014-09-16 04:51:44]

@eseidel, @abarth: this was landed previously but was reverted due to
browser_tests failure. The chromium dependent patch is here:
https://codereview.chromium.org/567153002

[vivekg, 2014-12-22 15:43:49]

vivekg@chromium.org changed reviewers:
+ jochen@chromium.org

[vivekg, 2014-12-22 15:45:41]

+jochen, PTAL. This dependent patches have landed and the linux_chromium_rel_ng
bot turned green.

The other bots are red as the dependent patches are not yet updated in their
respective repos.

[jochen (gone - plz use gerrit), 2014-12-22 15:48:16]

lgtm

[vivekg, 2014-12-22 16:00:26]

On 2014/12/22 at 15:48:16, jochen wrote:
> lgtm

Thanks. There is a failure with the html_viewer_tests located inside mojo
directory here [1]. 
Do we need to fix these as well? I think the fixes would be in the mojo github
repo right for this.

[1]
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...

[jochen (gone - plz use gerrit), 2014-12-22 16:04:39]

yeah, although I'm not sure what to do there. I'd ask jamesr@

[vivekg, 2014-12-22 16:06:07]

vivekg@chromium.org changed reviewers:
+ jamesr@chromium.org

[vivekg, 2014-12-22 16:06:42]

On 2014/12/22 at 16:04:39, jochen wrote:
> yeah, although I'm not sure what to do there. I'd ask jamesr@

Sure. 

+ jamesr@. Please suggest.

[vivekg, 2014-12-23 15:33:35]

I verified with the source located in [1] and got to know that the http_viewer
is not present in mojo/services directory.

So, is the source I am looking at different than the src/mojo/services directory
of chromium? 

[1] https://github.com/domokit/mojo/tree/master/services

[vivekg, 2014-12-23 15:58:14]

vivekg@chromium.org changed reviewers:
+ dtapuska@chromium.org
- abarth@chromium.org, eseidel@chromium.org

[vivekg, 2014-12-23 17:24:30]

The html_viewer_unittests are failing as there is no implementation of
blink::Platform::loadResource() in
mojo/services/html_viewer/blink_platform_impl.h/cpp at [1].

Now there are multiple ways in which this can be achieved. e.g. making
BlinkPlatformImpl::loadResource to explicitly load the blink_resources.pak file
into the shared resource bundle and return the associated data.

Please let me know what way is a better approach to resolve this issue. Thanks!

[1]
https://code.google.com/p/chromium/codesearch#chromium/src/mojo/services/html...

[jamesr, 2014-12-30 00:51:01]

html_viewer lives exclusively in the chromium repo.  We don't have a great
general way to refer to resources in a mojo app context.  Could you compile the
.pak into html_viewer and implemented loadResource in terms of that?

[vivekg, 2014-12-30 07:03:21]

On 2014/12/30 at 00:51:01, jamesr wrote:
> html_viewer lives exclusively in the chromium repo.  We don't have a great
general way to refer to resources in a mojo app context.  Could you compile the
.pak into html_viewer and implemented loadResource in terms of that?

Sure, I have uploaded a CL to do this job here
https://codereview.chromium.org/827223002. PTAL.

[vivekg, 2015-01-14 06:47:41]

The CQ bit was checked by vivekg@chromium.org

[vivekg, 2015-01-14 06:47:48]

The CQ bit was unchecked by vivekg@chromium.org

[vivekg, 2015-01-14 08:22:50]

jochen@, now that patch https://codereview.chromium.org/827223002 has landed, it
should be fine to go ahead with landing this one. 

Can you please rubber stamp it?

[jochen (gone - plz use gerrit), 2015-01-14 13:23:12]

lgtm

[vivekg, 2015-01-14 13:53:32]

The CQ bit was checked by vivekg@chromium.org

[commit-bot: I haz the power, 2015-01-14 13:54:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/573553002/60001

[commit-bot: I haz the power, 2015-01-14 13:57:55]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188383

[Zhenyao Mo, 2015-01-14 18:15:19]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/852033002/ by zmo@chromium.org.

The reason for reverting is: This caused 
BatteryMonitorIntegrationTest.DefaultValues
BatteryMonitorIntegrationTest.EventListener
BatteryMonitorIntegrationTest.ResolvePromise

to time out on android debug bots.

One example:
http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg...

C 1558.589s Main  Detailed Logs
C 1558.589s Main 
********************************************************************************
C 1558.590s Main  [TIMEOUT] BatteryMonitorIntegrationTest.DefaultValues:
C 1558.590s Main  [WARNING:dns_config_service_posix.cc(293)] Failed to read
DnsConfig.
C 1558.590s Main  [ERROR:unix_domain_server_socket_posix.cc(106)] Not
implemented reached in virtual int
net::UnixDomainServerSocket::GetLocalAddress(net::IPEndPoint*) const
C 1558.590s Main  [WARNING:proxy_service.cc(899)] PAC support disabled because
there is no system implementation
C 1558.590s Main  
C 1558.590s Main  [TIMEOUT] BatteryMonitorIntegrationTest.EventListener:
C 1558.590s Main  [WARNING:dns_config_service_posix.cc(293)] Failed to read
DnsConfig.
C 1558.590s Main  [ERROR:unix_domain_server_socket_posix.cc(106)] Not
implemented reached in virtual int
net::UnixDomainServerSocket::GetLocalAddress(net::IPEndPoint*) const
C 1558.590s Main  [WARNING:proxy_service.cc(899)] PAC support disabled because
there is no system implementation
C 1558.590s Main  [WARNING:channel.cc(136)] WriteMessage() while shutting down
C 1558.590s Main  [WARNING:channel.cc(553)] Failed to send message to remove
remote endpoint (local ID 3, remote ID 2147483649)
C 1558.590s Main  [WARNING:channel.cc(320)] RawChannel write error
C 1558.590s Main  
C 1558.591s Main  [TIMEOUT] BatteryMonitorIntegrationTest.ResolvePromise:
C 1558.591s Main  [WARNING:dns_config_service_posix.cc(293)] Failed to read
DnsConfig.
C 1558.591s Main  [ERROR:unix_domain_server_socket_posix.cc(106)] Not
implemented reached in virtual int
net::UnixDomainServerSocket::GetLocalAddress(net::IPEndPoint*) const
C 1558.591s Main  [WARNING:proxy_service.cc(899)] PAC support disabled because
there is no system implementation
C 1558.591s Main  [WARNING:channel.cc(136)] WriteMessage() while shutting down
C 1558.591s Main  [WARNING:channel.cc(136)] WriteMessage() while shutting down.