Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issue 567153002: Utilize TestContentClient in RenderViewTest as resources are being migrated to using grd system. (Closed)

Created:
6 years, 3 months ago by vivekg_samsung
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Utilize TestContentClient in RenderViewTest as resources are being migrated to using grd system. Blink is about to use blink_resources.grd for the inline resources of user agent stylesheets. This removes the dependency upon using make-file-arrays.py which embeds these resources as strings. This patch instantiates TestContentClient which does all the plumbing required for various test targets in content. As the resources are being moved into blink_resources.grd, this generates blink_resources.pak. This pak doesn't exists as a separate pak file but its repacked into "content_shell.pak". This blink side changes were reverted here https://codereview.chromium.org/567073004/ The reason for reverting: Breaking quite a few browser_tests and content_browsertests across multiple platforms. BUG=312586 Committed: https://crrev.com/a5827f8eef9041dd95fa1268694d625e7a8c5631 Cr-Commit-Position: refs/heads/master@{#295071}

Patch Set 1 #

Patch Set 2 : Adding the isolate deps required for mac swarming #

Patch Set 3 : Adding correct isolate file #

Patch Set 4 : Err.. Replaced previous one! #

Patch Set 5 : Sigh!!! ChromeOS dependency! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M chrome/browser_tests.isolate View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M content/content_browsertests.isolate View 1 2 3 4 1 chunk +14 lines, -0 lines 0 comments Download
M content/public/test/render_view_test.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
vivekg
Missed this in the earlier patch. PTAL, thanks!
6 years, 3 months ago (2014-09-13 05:01:06 UTC) #2
vivekg
On 2014/09/13 at 05:01:06, vivekg_ wrote: > Missed this in the earlier patch. PTAL, thanks! ...
6 years, 3 months ago (2014-09-15 05:53:25 UTC) #3
vivekg
Friendly ping. :)
6 years, 3 months ago (2014-09-16 09:39:07 UTC) #4
jochen (gone - plz use gerrit)
lgtm
6 years, 3 months ago (2014-09-16 14:28:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/567153002/80001
6 years, 3 months ago (2014-09-16 14:29:05 UTC) #7
commit-bot: I haz the power
Committed patchset #5 (id:80001) as c4354d9526408890a560e8a9c7b4c53b62e657bc
6 years, 3 months ago (2014-09-16 15:25:50 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 15:27:04 UTC) #9
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/a5827f8eef9041dd95fa1268694d625e7a8c5631
Cr-Commit-Position: refs/heads/master@{#295071}

Powered by Google App Engine
This is Rietveld 408576698