Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 819573002: Migrate PasswordFormConversionUtilsTest from browser_tests to be a component_browsertests (Closed)

Created:
6 years ago by vivekg_samsung
Modified:
6 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate PasswordFormConversionUtilsTest from browser_tests to be a component_browsertests Due to this test currently being a browser_test, its causing issues in migration of inline CSS resources to be part of GRD resources [1]. In order to fix this, this test has to be a component_browsertests. BUG=283846 R=jochen@chromium.org R=blundell@chromium.org [1] https://codereview.chromium.org/573553002 Committed: https://crrev.com/71e305ee3059cd9caf90e92fe68b990bf93d9e52 Cr-Commit-Position: refs/heads/master@{#309422}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M components/components_tests.gyp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
vivekg
PTAL, thanks.
6 years ago (2014-12-19 09:14:59 UTC) #2
vivekg
@jochen, wdyt?
6 years ago (2014-12-22 05:25:57 UTC) #3
jochen (gone - plz use gerrit)
lgtm
6 years ago (2014-12-22 14:19:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/819573002/1
6 years ago (2014-12-22 14:20:32 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-22 14:34:53 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-22 14:35:43 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/71e305ee3059cd9caf90e92fe68b990bf93d9e52
Cr-Commit-Position: refs/heads/master@{#309422}

Powered by Google App Engine
This is Rietveld 408576698