Move the user agent styles sheets to blink_resources.grd (Part 2)

Move the user agent styles sheets to blink_resources.grd (Part 2)

Blink should make use of blink_resources.grd for the inline resources of user agent stylesheets.
This removes the dependency upon using make-file-arrays.py which embeds these resources as strings.

Also the .rodata section of libblink_web (in component build mode) is reduced by ~33kb.

Part 1: https://codereview.chromium.org/436843004/
Part 1 with conditional: https://codereview.chromium.org/440683004/
Part 3: https://codereview.chromium.org/438843004/

BUG=312586
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287532

[vivekg, 2014-08-01 18:18:34]

PTAL, thank you.

[abarth-chromium, 2014-08-01 19:12:25]

lgtm

[vivekg, 2014-08-03 11:43:07]

Thank you @abarth.

@jochen, OWNERs review please?

[jochen (gone - plz use gerrit), 2014-08-04 08:35:05]

https://codereview.chromium.org/422023008/diff/1/content/child/blink_platform...
File content/child/blink_platform_impl.cc (right):

https://codereview.chromium.org/422023008/diff/1/content/child/blink_platform...
content/child/blink_platform_impl.cc:762: { "themeChromiumAndroid.css",
IDR_UASTYLE_THEME_CHROMIUM_ANDROID_CSS,
should this be compiled in only on android?

https://codereview.chromium.org/422023008/diff/1/content/child/blink_platform...
content/child/blink_platform_impl.cc:764: { "themeChromiumLinux.css",
IDR_UASTYLE_THEME_CHROMIUM_LINUX_CSS,
and this only on linux? etc..

https://codereview.chromium.org/422023008/diff/1/content/child/blink_platform...
content/child/blink_platform_impl.cc:777: { "mathml.css",
IDR_UASTYLE_MATHML_CSS, ui::SCALE_FACTOR_NONE},
why do we need this file? I thought we dropped mathml support a while ago?

[vivekg, 2014-08-04 15:04:40]

Thank you!

https://codereview.chromium.org/422023008/diff/1/content/child/blink_platform...
File content/child/blink_platform_impl.cc (right):

https://codereview.chromium.org/422023008/diff/1/content/child/blink_platform...
content/child/blink_platform_impl.cc:762: { "themeChromiumAndroid.css",
IDR_UASTYLE_THEME_CHROMIUM_ANDROID_CSS,
On 2014/08/04 08:35:05, jochen wrote:
> should this be compiled in only on android?

Done.

https://codereview.chromium.org/422023008/diff/1/content/child/blink_platform...
content/child/blink_platform_impl.cc:764: { "themeChromiumLinux.css",
IDR_UASTYLE_THEME_CHROMIUM_LINUX_CSS,
On 2014/08/04 08:35:05, jochen wrote:
> and this only on linux? etc..

Done.

https://codereview.chromium.org/422023008/diff/1/content/child/blink_platform...
content/child/blink_platform_impl.cc:777: { "mathml.css",
IDR_UASTYLE_MATHML_CSS, ui::SCALE_FACTOR_NONE},
On 2014/08/04 08:35:05, jochen wrote:
> why do we need this file? I thought we dropped mathml support a while ago?

I also had the same doubt about this MathML stuff being here. But I think we can
tackle this in a separate CL may be. Thoughts?

[vivekg, 2014-08-04 15:06:34]

Corresponding CL to make the conditional changes in grd is here
https://codereview.chromium.org/440683004/

[jochen (gone - plz use gerrit), 2014-08-04 15:50:25]

separate cl for mathml is fine, as you prefer

https://codereview.chromium.org/422023008/diff/20001/content/child/blink_plat...
File content/child/blink_platform_impl.cc (right):

https://codereview.chromium.org/422023008/diff/20001/content/child/blink_plat...
content/child/blink_platform_impl.cc:768: #if !defined(OS_WIN)
does mac use this as well?

https://codereview.chromium.org/422023008/diff/20001/content/child/blink_plat...
content/child/blink_platform_impl.cc:776: { "themeMac.css",
IDR_UASTYLE_THEME_MAC_CSS, ui::SCALE_FACTOR_NONE },
only for mac?

https://codereview.chromium.org/422023008/diff/20001/content/child/blink_plat...
content/child/blink_platform_impl.cc:777: { "themeWin.css",
IDR_UASTYLE_THEME_WIN_CSS, ui::SCALE_FACTOR_NONE },
only for win?

https://codereview.chromium.org/422023008/diff/20001/content/child/blink_plat...
content/child/blink_platform_impl.cc:788: { "viewportAndroid.css",
IDR_UASTYLE_VIEWPORT_ANDROID_CSS,
only for android

[vivekg, 2014-08-05 06:50:22]

https://codereview.chromium.org/422023008/diff/20001/content/child/blink_plat...
File content/child/blink_platform_impl.cc (right):

https://codereview.chromium.org/422023008/diff/20001/content/child/blink_plat...
content/child/blink_platform_impl.cc:768: #if !defined(OS_WIN)
On 2014/08/04 15:50:25, jochen wrote:
> does mac use this as well?

No. Its being used for OS(LINUX) and OS(ANDROID) here [1]

[1]
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

https://codereview.chromium.org/422023008/diff/20001/content/child/blink_plat...
content/child/blink_platform_impl.cc:776: { "themeMac.css",
IDR_UASTYLE_THEME_MAC_CSS, ui::SCALE_FACTOR_NONE },
On 2014/08/04 15:50:25, jochen wrote:
> only for mac?

Done.

https://codereview.chromium.org/422023008/diff/20001/content/child/blink_plat...
content/child/blink_platform_impl.cc:777: { "themeWin.css",
IDR_UASTYLE_THEME_WIN_CSS, ui::SCALE_FACTOR_NONE },
On 2014/08/04 15:50:25, jochen wrote:
> only for win?

This is again being used in linux as well (!!!) [1] There is a FIXME [2] which
states about separating the os specific details in another way. 

[1] 
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

[2]
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

https://codereview.chromium.org/422023008/diff/20001/content/child/blink_plat...
content/child/blink_platform_impl.cc:788: { "viewportAndroid.css",
IDR_UASTYLE_VIEWPORT_ANDROID_CSS,
On 2014/08/04 15:50:25, jochen wrote:
> only for android

This is used by inspector when applying Viewport Style Override here

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

[jochen (gone - plz use gerrit), 2014-08-05 09:05:21]

thanks for investigating this!

lgtm

[vivekg, 2014-08-05 10:55:49]

The CQ bit was checked by vivekg@chromium.org

[commit-bot: I haz the power, 2014-08-05 10:56:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/422023008/40001

[commit-bot: I haz the power, 2014-08-05 13:41:07]

Change committed as 287532