Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 852033002: Revert of Move the user agent styles sheets to blink_resources.grd (Part 3) (Closed)

Created:
5 years, 11 months ago by Zhenyao Mo
Modified:
5 years, 11 months ago
CC:
jochen (gone - plz use gerrit), aandrey+blink_chromium.org, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-rendering, caseq+blink_chromium.org, devtools-reviews_chromium.org, dglazkov+blink, eae+blinkwatch, ed+blinkwatch_opera.com, eustas+blink_chromium.org, jchaffraix+rendering, leviw+renderwatch, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, mkwst+moarreviews_chromium.org, paulirish+reviews_chromium.org, pdr., pfeldman+blink_chromium.org, rwlbuis, rune+blink, sergeyv+blink_chromium.org, vsevik+blink_chromium.org, yurys+blink_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Move the user agent styles sheets to blink_resources.grd (Part 3) (patchset #4 id:60001 of https://codereview.chromium.org/573553002/) Reason for revert: This caused BatteryMonitorIntegrationTest.DefaultValues BatteryMonitorIntegrationTest.EventListener BatteryMonitorIntegrationTest.ResolvePromise to time out on android debug bots. One example: http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29/builds/23812 C 1558.589s Main Detailed Logs C 1558.589s Main ******************************************************************************** C 1558.590s Main [TIMEOUT] BatteryMonitorIntegrationTest.DefaultValues: C 1558.590s Main [WARNING:dns_config_service_posix.cc(293)] Failed to read DnsConfig. C 1558.590s Main [ERROR:unix_domain_server_socket_posix.cc(106)] Not implemented reached in virtual int net::UnixDomainServerSocket::GetLocalAddress(net::IPEndPoint*) const C 1558.590s Main [WARNING:proxy_service.cc(899)] PAC support disabled because there is no system implementation C 1558.590s Main C 1558.590s Main [TIMEOUT] BatteryMonitorIntegrationTest.EventListener: C 1558.590s Main [WARNING:dns_config_service_posix.cc(293)] Failed to read DnsConfig. C 1558.590s Main [ERROR:unix_domain_server_socket_posix.cc(106)] Not implemented reached in virtual int net::UnixDomainServerSocket::GetLocalAddress(net::IPEndPoint*) const C 1558.590s Main [WARNING:proxy_service.cc(899)] PAC support disabled because there is no system implementation C 1558.590s Main [WARNING:channel.cc(136)] WriteMessage() while shutting down C 1558.590s Main [WARNING:channel.cc(553)] Failed to send message to remove remote endpoint (local ID 3, remote ID 2147483649) C 1558.590s Main [WARNING:channel.cc(320)] RawChannel write error C 1558.590s Main C 1558.591s Main [TIMEOUT] BatteryMonitorIntegrationTest.ResolvePromise: C 1558.591s Main [WARNING:dns_config_service_posix.cc(293)] Failed to read DnsConfig. C 1558.591s Main [ERROR:unix_domain_server_socket_posix.cc(106)] Not implemented reached in virtual int net::UnixDomainServerSocket::GetLocalAddress(net::IPEndPoint*) const C 1558.591s Main [WARNING:proxy_service.cc(899)] PAC support disabled because there is no system implementation C 1558.591s Main [WARNING:channel.cc(136)] WriteMessage() while shutting down C 1558.591s Main [WARNING:channel.cc(136)] WriteMessage() while shutting down Original issue's description: > Reland Move the user agent styles sheets to blink_resources.grd (Part 3) > > Blink should make use of blink_resources.grd for the inline resources of user agent stylesheets. > This removes the dependency upon using make-file-arrays.py which embeds these resources as strings. > > Also the .rodata section of libblink_web (in component build mode) is reduced by ~33kb. > > Part 1: https://codereview.chromium.org/436843004/ > Part 2: https://codereview.chromium.org/422023008 > > The chromium dependent patches [1] and [2] have already landed. > > [1] https://codereview.chromium.org/818563003 > [2] https://codereview.chromium.org/819573002 > > BUG=312586 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188383 TBR=jochen@chromium.org,dtapuska@chromium.org,jamesr@chromium.org,vivekg@chromium.org,vivek.vg@samsung.com NOTREECHECKS=true NOTRY=true BUG=312586 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188404

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -34 lines) Patch
M Source/core/BUILD.gn View 3 chunks +44 lines, -0 lines 0 comments Download
M Source/core/core.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/core_generated.gyp View 1 chunk +46 lines, -0 lines 0 comments Download
M Source/core/css/CSSDefaultStyleSheets.cpp View 12 chunks +16 lines, -11 lines 0 comments Download
M Source/core/inspector/InspectorPageAgent.cpp View 3 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumAndroid.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumDefault.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumLinux.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumMac.mm View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumSkia.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/platform/PlatformResourceLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 3 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Zhenyao Mo
Created Revert of Move the user agent styles sheets to blink_resources.grd (Part 3)
5 years, 11 months ago (2015-01-14 18:15:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/852033002/1
5 years, 11 months ago (2015-01-14 18:15:35 UTC) #2
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 18:16:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188404

Powered by Google App Engine
This is Rietveld 408576698