DescriptionRevert of Move the user agent styles sheets to blink_resources.grd (Part 3) (patchset #4 id:60001 of https://codereview.chromium.org/573553002/)
Reason for revert:
This caused
BatteryMonitorIntegrationTest.DefaultValues
BatteryMonitorIntegrationTest.EventListener BatteryMonitorIntegrationTest.ResolvePromise
to time out on android debug bots.
One example: http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29/builds/23812
C 1558.589s Main Detailed Logs
C 1558.589s Main ********************************************************************************
C 1558.590s Main [TIMEOUT] BatteryMonitorIntegrationTest.DefaultValues:
C 1558.590s Main [WARNING:dns_config_service_posix.cc(293)] Failed to read DnsConfig.
C 1558.590s Main [ERROR:unix_domain_server_socket_posix.cc(106)] Not implemented reached in virtual int net::UnixDomainServerSocket::GetLocalAddress(net::IPEndPoint*) const
C 1558.590s Main [WARNING:proxy_service.cc(899)] PAC support disabled because there is no system implementation
C 1558.590s Main
C 1558.590s Main [TIMEOUT] BatteryMonitorIntegrationTest.EventListener:
C 1558.590s Main [WARNING:dns_config_service_posix.cc(293)] Failed to read DnsConfig.
C 1558.590s Main [ERROR:unix_domain_server_socket_posix.cc(106)] Not implemented reached in virtual int net::UnixDomainServerSocket::GetLocalAddress(net::IPEndPoint*) const
C 1558.590s Main [WARNING:proxy_service.cc(899)] PAC support disabled because there is no system implementation
C 1558.590s Main [WARNING:channel.cc(136)] WriteMessage() while shutting down
C 1558.590s Main [WARNING:channel.cc(553)] Failed to send message to remove remote endpoint (local ID 3, remote ID 2147483649)
C 1558.590s Main [WARNING:channel.cc(320)] RawChannel write error
C 1558.590s Main
C 1558.591s Main [TIMEOUT] BatteryMonitorIntegrationTest.ResolvePromise:
C 1558.591s Main [WARNING:dns_config_service_posix.cc(293)] Failed to read DnsConfig.
C 1558.591s Main [ERROR:unix_domain_server_socket_posix.cc(106)] Not implemented reached in virtual int net::UnixDomainServerSocket::GetLocalAddress(net::IPEndPoint*) const
C 1558.591s Main [WARNING:proxy_service.cc(899)] PAC support disabled because there is no system implementation
C 1558.591s Main [WARNING:channel.cc(136)] WriteMessage() while shutting down
C 1558.591s Main [WARNING:channel.cc(136)] WriteMessage() while shutting down
Original issue's description:
> Reland Move the user agent styles sheets to blink_resources.grd (Part 3)
>
> Blink should make use of blink_resources.grd for the inline resources of user agent stylesheets.
> This removes the dependency upon using make-file-arrays.py which embeds these resources as strings.
>
> Also the .rodata section of libblink_web (in component build mode) is reduced by ~33kb.
>
> Part 1: https://codereview.chromium.org/436843004/
> Part 2: https://codereview.chromium.org/422023008
>
> The chromium dependent patches [1] and [2] have already landed.
>
> [1] https://codereview.chromium.org/818563003
> [2] https://codereview.chromium.org/819573002
>
> BUG=312586
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188383
TBR=jochen@chromium.org,dtapuska@chromium.org,jamesr@chromium.org,vivekg@chromium.org,vivek.vg@samsung.com
NOTREECHECKS=true
NOTRY=true
BUG=312586
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188404
Patch Set 1 #
Created: 5 years, 11 months ago
(Patch set is too large to download)
Messages
Total messages: 3 (0 generated)
|