Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1981)

Issue 818563003: Tests in browser_tests target should use ChromeRenderViewTest as the base class. (Closed)

Created:
6 years ago by vivekg_samsung
Modified:
6 years ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, estade+watch_chromium.org, extensions-reviews_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Tests in browser_tests target should use ChromeRenderViewTest as the base class. Currently these tests are utilizing the content::RenderViewTest as the base class whereas all other *_browsertest.cc are using ChromeRenderViewTest as the base class. Due to this, the migration of inline CSS to GRD being done in [1] is failing for browsertests target as listed here [2] in the build log. In order to fix this, these tests should use the ChromeRenderViewTest as their base class. In doing so, the ChromeRenderViewTest loads ChromeContentClient which in turn loads the correct pak file i.e. resources.pak required for the migration. This CL adds the extensions/DEPS rule to allow the inclusion of chrome_render_view_test.h. [1] https://codereview.chromium.org/573553002 [2] http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/14184 Committed: https://crrev.com/d155cb80c7b61e65f3999df1718c3be6e3cce0b4 Cr-Commit-Position: refs/heads/master@{#309424}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M chrome/renderer/autofill/page_click_tracker_browsertest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M extensions/DEPS View 1 chunk +1 line, -0 lines 1 comment Download
M extensions/renderer/script_context_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
vivekg
PTAL, thanks! @jochen: chrome/* @benwells: extensions/*
6 years ago (2014-12-19 04:44:27 UTC) #2
benwells
-me, +yoz
6 years ago (2014-12-19 05:46:49 UTC) #4
Yoyo Zhou
LGTM https://codereview.chromium.org/818563003/diff/1/extensions/DEPS File extensions/DEPS (right): https://codereview.chromium.org/818563003/diff/1/extensions/DEPS#newcode51 extensions/DEPS:51: "+chrome/test/base/chrome_render_view_test.h", I don't like this change, but we ...
6 years ago (2014-12-19 23:08:38 UTC) #5
vivekg
@jochen, wdyt?
6 years ago (2014-12-22 05:25:24 UTC) #6
jochen (gone - plz use gerrit)
lgtm
6 years ago (2014-12-22 14:19:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/818563003/1
6 years ago (2014-12-22 14:23:30 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-22 14:37:39 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-22 14:39:09 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d155cb80c7b61e65f3999df1718c3be6e3cce0b4
Cr-Commit-Position: refs/heads/master@{#309424}

Powered by Google App Engine
This is Rietveld 408576698