DescriptionTests in browser_tests target should use ChromeRenderViewTest as the base class.
Currently these tests are utilizing the content::RenderViewTest as the base class
whereas all other *_browsertest.cc are using ChromeRenderViewTest as the base class.
Due to this, the migration of inline CSS to GRD being done in [1] is failing
for browsertests target as listed here [2] in the build log.
In order to fix this, these tests should use the ChromeRenderViewTest as their base class.
In doing so, the ChromeRenderViewTest loads ChromeContentClient which in turn loads the correct
pak file i.e. resources.pak required for the migration.
This CL adds the extensions/DEPS rule to allow the inclusion of chrome_render_view_test.h.
[1] https://codereview.chromium.org/573553002
[2] http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/14184
Committed: https://crrev.com/d155cb80c7b61e65f3999df1718c3be6e3cce0b4
Cr-Commit-Position: refs/heads/master@{#309424}
Patch Set 1 #
Total comments: 1
Messages
Total messages: 11 (3 generated)
|