Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 572013002: Removing ContentViewCore dependencies from direct WebContents functions. (Closed)

Created:
6 years, 3 months ago by AKVT
Modified:
6 years, 2 months ago
Reviewers:
Ted C, Yaron, boliu
CC:
chromium-reviews, David Trainor- moved to gerrit, jam, dtseng+watch_chromium.org, plundblad+watch_chromium.org, mkwst+moarreviews-content_chromium.org, benquan, avayvod+watch_chromium.org, browser-components-watch_chromium.org, yuzo+watch_chromium.org, aboxhall+watch_chromium.org, jochen+watch_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, Ilya Sherman, android-webview-reviews_chromium.org, rouslan+autofillwatch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Removing ContentViewCore dependencies from direct WebContents functions. It's a follow up patch to https://codereview.chromium.org/481803004/ We already restructured WebContents functionalities from ContentViewCore. In this patch we are removing unwanted ContentViewCore methods, so that ContentViewCore stake holders can directly call these methods. BUG=398263 Committed: https://crrev.com/28b377a0993f6b6d3367016749b54c3d4fcd1839 Cr-Commit-Position: refs/heads/master@{#299246}

Patch Set 1 #

Patch Set 2 : Corrected the comment. #

Patch Set 3 : Fixed the build breaks. #

Patch Set 4 : Fixed the native crash. #

Patch Set 5 : Fixed nits. #

Total comments: 6

Patch Set 6 : Rebased the patch and addressed review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+278 lines, -328 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenVideoTest.java View 1 2 3 4 6 chunks +6 lines, -5 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/util/JSUtils.java View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/Tab.java View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillDialogControllerTest.java View 6 chunks +38 lines, -36 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java View 6 chunks +17 lines, -14 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectFileDialogTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/test/ModalDialogTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/sync_shell/javatests/src/chromium/chrome/browser/sync/SyncTest.java View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 2 3 4 5 9 chunks +26 lines, -125 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/accessibility/AccessibilityInjector.java View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/accessibility/JellyBeanAccessibilityInjector.java View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ContentDetectionTestBase.java View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ContentViewLocationTest.java View 1 2 3 4 6 chunks +8 lines, -8 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ContentViewTestBase.java View 1 2 3 4 5 3 chunks +7 lines, -5 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/GestureDetectorResetTest.java View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/InterstitialPageTest.java View 2 chunks +3 lines, -4 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeChildFrameTest.java View 1 2 3 4 7 chunks +12 lines, -11 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeTestBase.java View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/NavigationTest.java View 1 2 3 4 4 chunks +24 lines, -24 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/PostMessageTest.java View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/TestsJavaScriptEvalTest.java View 1 2 3 2 chunks +7 lines, -3 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/TransitionTest.java View 1 2 3 4 11 chunks +23 lines, -16 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ViewportTest.java View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java View 1 2 3 15 chunks +20 lines, -17 lines 0 comments Download
M content/public/test/android/javatests/src/org/chromium/content/browser/test/util/DOMUtils.java View 10 chunks +24 lines, -23 lines 0 comments Download
M content/public/test/android/javatests/src/org/chromium/content/browser/test/util/JavaScriptUtils.java View 1 2 5 chunks +7 lines, -7 lines 0 comments Download
M content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestCallbackHelperContainer.java View 1 2 3 4 4 chunks +7 lines, -5 lines 0 comments Download
M content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestWebContentsObserver.java View 2 chunks +0 lines, -6 lines 0 comments Download
M content/shell/android/java/src/org/chromium/content_shell/Shell.java View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M content/shell/android/javatests/src/org/chromium/content_shell_apk/ContentShellTestBase.java View 1 2 3 4 3 chunks +12 lines, -2 lines 0 comments Download
M content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellActivity.java View 1 2 3 4 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (11 generated)
AKVT
@Ted & boliu PTAL
6 years, 3 months ago (2014-09-15 19:26:26 UTC) #2
boliu
On 2014/09/15 19:26:26, AKV wrote: > @Ted & boliu PTAL Fix your compile error first ...
6 years, 3 months ago (2014-09-15 21:16:28 UTC) #4
AKVT
@Yaron PTAL
6 years, 2 months ago (2014-10-08 09:16:56 UTC) #12
AKVT
@Yaron, Ted & boliu PTAL
6 years, 2 months ago (2014-10-09 16:51:08 UTC) #14
boliu
https://codereview.chromium.org/572013002/diff/230001/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java File android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java (right): https://codereview.chromium.org/572013002/diff/230001/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java#newcode150 android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java:150: if (webContents == null) return; This isn't the same ...
6 years, 2 months ago (2014-10-09 17:10:04 UTC) #15
Ted C
everything minus webview lgtm https://codereview.chromium.org/572013002/diff/230001/components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java File components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java (right): https://codereview.chromium.org/572013002/diff/230001/components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java#newcode141 components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java:141: * either of ContentViewCore.ContinuePendingReload or ...
6 years, 2 months ago (2014-10-10 17:00:53 UTC) #16
AKVT
@Ted Thanks. @Yaron & boliu PTAL https://codereview.chromium.org/572013002/diff/230001/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java File android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java (right): https://codereview.chromium.org/572013002/diff/230001/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java#newcode150 android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java:150: if (webContents == ...
6 years, 2 months ago (2014-10-11 10:51:59 UTC) #17
boliu
android_webview lgtm weee deleting code!
6 years, 2 months ago (2014-10-11 17:08:11 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/572013002/310001
6 years, 2 months ago (2014-10-11 18:16:05 UTC) #20
commit-bot: I haz the power
Committed patchset #6 (id:310001)
6 years, 2 months ago (2014-10-11 19:08:12 UTC) #21
commit-bot: I haz the power
6 years, 2 months ago (2014-10-11 19:08:50 UTC) #22
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/28b377a0993f6b6d3367016749b54c3d4fcd1839
Cr-Commit-Position: refs/heads/master@{#299246}

Powered by Google App Engine
This is Rietveld 408576698