chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectFileDialogTest.java - Issue 572013002: Removing ContentViewCore dependencies from direct WebContents functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectFileDialogTest.java

Issue 572013002: Removing ContentViewCore dependencies from direct WebContents functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased the patch and addressed review comments. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/test/ModalDialogTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectFileDialogTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectFileDialogTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectFileDialogTest.java

index e9a81acd1b76dba565e0dc546ae658dc3ae0b0bb..bf9eff188c88f15438cd31886433b554c44e0add 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectFileDialogTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectFileDialogTest.java

@@ -84,7 +84,7 @@ public class SelectFileDialogTest extends ChromeShellTestBase {

// TODO(aurimas) remove this wait once crbug.com/179511 is fixed.

assertWaitForPageScaleFactorMatch(2);

assertTrue(

- DOMUtils.waitForNonZeroNodeBounds(mContentViewCore, "input_file"));

+ DOMUtils.waitForNonZeroNodeBounds(mContentViewCore.getWebContents(), "input_file"));

}

/**