Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Side by Side Diff: components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java

Issue 572013002: Removing ContentViewCore dependencies from direct WebContents functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed nits. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.components.web_contents_delegate_android; 5 package org.chromium.components.web_contents_delegate_android;
6 6
7 import android.view.KeyEvent; 7 import android.view.KeyEvent;
8 8
9 import org.chromium.base.CalledByNative; 9 import org.chromium.base.CalledByNative;
10 import org.chromium.base.JNINamespace; 10 import org.chromium.base.JNINamespace;
11 import org.chromium.content.browser.ContentViewCore; 11 import org.chromium.content_public.browser.WebContents;
12 12
13 /** 13 /**
14 * Java peer of the native class of the same name. 14 * Java peer of the native class of the same name.
15 */ 15 */
16 @JNINamespace("web_contents_delegate_android") 16 @JNINamespace("web_contents_delegate_android")
17 public class WebContentsDelegateAndroid { 17 public class WebContentsDelegateAndroid {
18 18
19 // Equivalent of WebCore::WebConsoleMessage::LevelTip. 19 // Equivalent of WebCore::WebConsoleMessage::LevelTip.
20 public static final int LOG_LEVEL_TIP = 0; 20 public static final int LOG_LEVEL_TIP = 0;
21 // Equivalent of WebCore::WebConsoleMessage::LevelLog. 21 // Equivalent of WebCore::WebConsoleMessage::LevelLog.
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 * @return true if the client will handle logging the message. 131 * @return true if the client will handle logging the message.
132 */ 132 */
133 @CalledByNative 133 @CalledByNative
134 public boolean addMessageToConsole(int level, String message, int lineNumber , 134 public boolean addMessageToConsole(int level, String message, int lineNumber ,
135 String sourceId) { 135 String sourceId) {
136 return false; 136 return false;
137 } 137 }
138 138
139 /** 139 /**
140 * Report a form resubmission. The overwriter of this function should eventu ally call 140 * Report a form resubmission. The overwriter of this function should eventu ally call
141 * either of ContentViewCore.ContinuePendingReload or ContentViewCore.Cancel PendingReload. 141 * either of ContentViewCore.ContinuePendingReload or ContentViewCore.Cancel PendingReload.
Ted C 2014/10/10 17:00:53 This comment should be updated to NavigationContro
AKVT 2014/10/11 10:51:59 Done.
142 */ 142 */
143 @CalledByNative 143 @CalledByNative
144 public void showRepostFormWarningDialog(ContentViewCore contentViewCore) { 144 public void showRepostFormWarningDialog(WebContents webContents) {
145 } 145 }
146 146
147 @CalledByNative 147 @CalledByNative
148 public void toggleFullscreenModeForTab(boolean enterFullscreen) { 148 public void toggleFullscreenModeForTab(boolean enterFullscreen) {
149 } 149 }
150 150
151 @CalledByNative 151 @CalledByNative
152 public boolean isFullscreenForTabOrPending() { 152 public boolean isFullscreenForTabOrPending() {
153 return false; 153 return false;
154 } 154 }
155 } 155 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698