Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1774)

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/InterstitialPageTest.java

Issue 572013002: Removing ContentViewCore dependencies from direct WebContents functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased the patch and addressed review comments. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/javatests/src/org/chromium/content/browser/InterstitialPageTest.java
diff --git a/content/public/android/javatests/src/org/chromium/content/browser/InterstitialPageTest.java b/content/public/android/javatests/src/org/chromium/content/browser/InterstitialPageTest.java
index d23a626625e9d6d7c6e882df2ac3fda2dec7fef2..47fa6a73667ee6da97af9a6bbb46aaeb0870d363 100644
--- a/content/public/android/javatests/src/org/chromium/content/browser/InterstitialPageTest.java
+++ b/content/public/android/javatests/src/org/chromium/content/browser/InterstitialPageTest.java
@@ -71,7 +71,7 @@ public class InterstitialPageTest extends ContentShellTestBase {
@Override
public Boolean call() throws Exception {
return shouldBeShown
- == getContentViewCore().isShowingInterstitialPage();
+ == getWebContents().isShowingInterstitialPage();
}
});
} catch (ExecutionException e) {
@@ -115,9 +115,8 @@ public class InterstitialPageTest extends ContentShellTestBase {
new Callable<TestWebContentsObserverAndroid>() {
@Override
public TestWebContentsObserverAndroid call() throws Exception {
- getContentViewCore().showInterstitialPage(URL, delegate);
- return new TestWebContentsObserverAndroid(
- getContentViewCore().getWebContents());
+ getWebContents().showInterstitialPage(URL, delegate.getNative());
+ return new TestWebContentsObserverAndroid(getWebContents());
}
});

Powered by Google App Engine
This is Rietveld 408576698