Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Side by Side Diff: components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java

Issue 572013002: Removing ContentViewCore dependencies from direct WebContents functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased the patch and addressed review comments. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.components.web_contents_delegate_android; 5 package org.chromium.components.web_contents_delegate_android;
6 6
7 import android.view.KeyEvent; 7 import android.view.KeyEvent;
8 8
9 import org.chromium.base.CalledByNative; 9 import org.chromium.base.CalledByNative;
10 import org.chromium.base.JNINamespace; 10 import org.chromium.base.JNINamespace;
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 * @return true if the client will handle logging the message. 130 * @return true if the client will handle logging the message.
131 */ 131 */
132 @CalledByNative 132 @CalledByNative
133 public boolean addMessageToConsole(int level, String message, int lineNumber , 133 public boolean addMessageToConsole(int level, String message, int lineNumber ,
134 String sourceId) { 134 String sourceId) {
135 return false; 135 return false;
136 } 136 }
137 137
138 /** 138 /**
139 * Report a form resubmission. The overwriter of this function should eventu ally call 139 * Report a form resubmission. The overwriter of this function should eventu ally call
140 * either of ContentViewCore.ContinuePendingReload or ContentViewCore.Cancel PendingReload. 140 * either of NavigationController.ContinuePendingReload or
141 * NavigationController.CancelPendingReload.
141 */ 142 */
142 @CalledByNative 143 @CalledByNative
143 public void showRepostFormWarningDialog() { 144 public void showRepostFormWarningDialog() {
144 } 145 }
145 146
146 @CalledByNative 147 @CalledByNative
147 public void toggleFullscreenModeForTab(boolean enterFullscreen) { 148 public void toggleFullscreenModeForTab(boolean enterFullscreen) {
148 } 149 }
149 150
150 @CalledByNative 151 @CalledByNative
151 public boolean isFullscreenForTabOrPending() { 152 public boolean isFullscreenForTabOrPending() {
152 return false; 153 return false;
153 } 154 }
154 } 155 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698