content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestWebContentsObserver.java - Issue 572013002: Removing ContentViewCore dependencies from direct WebContents functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestWebContentsObserver.java

Issue 572013002: Removing ContentViewCore dependencies from direct WebContents functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased the patch and addressed review comments. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestCallbackHelperContainer.java ('k') | content/shell/android/java/src/org/chromium/content_shell/Shell.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestWebContentsObserver.java

diff --git a/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestWebContentsObserver.java b/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestWebContentsObserver.java

index 5872be16b532956b5193e67848d217428efae5ce..0cd968db4cd364abd794dfe5d0abb1e842cfc686 100644

--- a/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestWebContentsObserver.java

+++ b/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestWebContentsObserver.java

@@ -4,7 +4,6 @@

package org.chromium.content.browser.test.util;

-import org.chromium.content.browser.ContentViewCore;

import org.chromium.content.browser.WebContentsObserverAndroid;

import org.chromium.content.browser.test.util.TestCallbackHelperContainer.OnPageFinishedHelper;

import org.chromium.content.browser.test.util.TestCallbackHelperContainer.OnPageStartedHelper;

@@ -21,11 +20,6 @@ public class TestWebContentsObserver extends WebContentsObserverAndroid {

private final OnPageFinishedHelper mOnPageFinishedHelper;

private final OnReceivedErrorHelper mOnReceivedErrorHelper;

- // TODO(yfriedman): Switch everyone to use the WebContents constructor.

- public TestWebContentsObserver(ContentViewCore contentViewCore) {

- this(contentViewCore.getWebContents());

- }

public TestWebContentsObserver(WebContents webContents) {

super(webContents);

mOnPageStartedHelper = new OnPageStartedHelper();