Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issue 571643003: Remove app_shell chrome.shell API and ShellAppWindow (Closed)

Created:
6 years, 3 months ago by James Cook
Modified:
6 years, 3 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, jam, darin-cc_chromium.org, asvitkine+watch_chromium.org, chromium-apps-reviews_chromium.org, dharcourt, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove app_shell chrome.shell API and ShellAppWindow The chrome.app.window API has been moved to src/extensions, so app_shell no longer needs its custom chrome.shell API to open windows. * Remove the API implementation -- mostly a manual revert of https://codereview.chromium.org/254473011/ * Remove app_shell_resources.grd since there are no more app_shell resources * Remove athena's support for ShellAppWindow * Fix example apps to remove the chrome.shell workaround. No presubmit because it has a false-positive warning about the enum rename in extension_function_histogram_value.h No try because no presubmit doesn't seem to work by itself. BUG=413164 TEST=extensions_unittests, app_shell_unittests, app_shell_browsertests TBR=isherman@chromium.org for deprecating an extension function histogram NOPRESUBMIT=true NOTRY=true Committed: https://crrev.com/877e2ab661da959e844d0f0f1e71f815d32d8c77 Cr-Commit-Position: refs/heads/master@{#294852}

Patch Set 1 #

Patch Set 2 : (remove-shell) fix gn #

Patch Set 3 : (remove-shell) rebase #

Patch Set 4 : (remove-shell) rebase 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -823 lines) Patch
M athena/activity/public/activity_factory.h View 2 chunks +0 lines, -8 lines 0 comments Download
M athena/content/chrome/content_activity_factory.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M athena/content/content_activity_factory.h View 1 chunk +0 lines, -2 lines 0 comments Download
M athena/content/shell/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M athena/content/shell/content_activity_factory.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M athena/content/shell/shell_app_activity.h View 3 chunks +0 lines, -5 lines 0 comments Download
M athena/content/shell/shell_app_activity.cc View 2 chunks +3 lines, -11 lines 0 comments Download
M athena/main/athena_main.cc View 2 chunks +1 line, -14 lines 0 comments Download
M athena/test/sample_activity_factory.h View 1 chunk +0 lines, -2 lines 0 comments Download
M athena/test/sample_activity_factory.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/common/extensions/docs/examples/apps/calculator/app/controller.js View 1 chunk +1 line, -5 lines 0 comments Download
M extensions/BUILD.gn View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M extensions/browser/extension_function_histogram_value.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M extensions/extensions.gyp View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
D extensions/shell/BUILD.gn View 1 chunk +0 lines, -13 lines 0 comments Download
M extensions/shell/DEPS View 1 chunk +1 line, -2 lines 0 comments Download
M extensions/shell/app_shell.gyp View 4 chunks +0 lines, -11 lines 0 comments Download
D extensions/shell/app_shell_resources.grd View 1 chunk +0 lines, -18 lines 0 comments Download
D extensions/shell/app_shell_resources.gyp View 1 chunk +0 lines, -25 lines 0 comments Download
D extensions/shell/browser/api/api_registration.gyp View 1 chunk +0 lines, -22 lines 0 comments Download
D extensions/shell/browser/api/shell/shell_api.h View 1 chunk +0 lines, -33 lines 0 comments Download
D extensions/shell/browser/api/shell/shell_api.cc View 1 chunk +0 lines, -66 lines 0 comments Download
M extensions/shell/browser/desktop_controller.h View 3 chunks +4 lines, -9 lines 0 comments Download
D extensions/shell/browser/shell_app_window.h View 1 chunk +0 lines, -86 lines 0 comments Download
D extensions/shell/browser/shell_app_window.cc View 1 chunk +0 lines, -91 lines 0 comments Download
M extensions/shell/browser/shell_desktop_controller.h View 3 chunks +0 lines, -5 lines 0 comments Download
M extensions/shell/browser/shell_desktop_controller.cc View 3 chunks +3 lines, -18 lines 0 comments Download
M extensions/shell/browser/shell_extension_system.cc View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/shell/browser/shell_extensions_browser_client.cc View 2 chunks +0 lines, -4 lines 0 comments Download
D extensions/shell/common/api/_api_features.json View 1 chunk +0 lines, -18 lines 0 comments Download
D extensions/shell/common/api/api.gyp View 1 chunk +0 lines, -19 lines 0 comments Download
D extensions/shell/common/api/schemas.gypi View 1 chunk +0 lines, -20 lines 0 comments Download
D extensions/shell/common/api/shell.idl View 1 chunk +0 lines, -36 lines 0 comments Download
M extensions/shell/common/shell_extensions_client.cc View 3 chunks +1 line, -13 lines 0 comments Download
M extensions/shell/renderer/shell_content_renderer_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D extensions/shell/renderer/shell_custom_bindings.h View 1 chunk +0 lines, -25 lines 0 comments Download
D extensions/shell/renderer/shell_custom_bindings.cc View 1 chunk +0 lines, -57 lines 0 comments Download
D extensions/shell/renderer/shell_custom_bindings.js View 1 chunk +0 lines, -78 lines 0 comments Download
D extensions/shell/renderer/shell_dispatcher_delegate.h View 1 chunk +0 lines, -33 lines 0 comments Download
D extensions/shell/renderer/shell_dispatcher_delegate.cc View 1 chunk +0 lines, -35 lines 0 comments Download
M extensions/test/data/platform_app/background.js View 1 chunk +1 line, -5 lines 0 comments Download
M tools/gritsettings/resource_ids View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (6 generated)
James Cook
rockot, PTAL at extensions/* oshima, PTAL at athena/*
6 years, 3 months ago (2014-09-12 21:44:25 UTC) #2
oshima
athena lgtm
6 years, 3 months ago (2014-09-12 22:56:39 UTC) #3
Ken Rockot(use gerrit already)
lgtm
6 years, 3 months ago (2014-09-12 23:52:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/571643003/40001
6 years, 3 months ago (2014-09-13 00:18:32 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/10786)
6 years, 3 months ago (2014-09-13 01:16:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/571643003/60001
6 years, 3 months ago (2014-09-15 16:19:34 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/10990)
6 years, 3 months ago (2014-09-15 16:40:06 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/571643003/60001
6 years, 3 months ago (2014-09-15 18:02:02 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 07316bf01fe4aa54b8c85babdce7a3e538d2ac6b
6 years, 3 months ago (2014-09-15 18:29:04 UTC) #15
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 18:34:50 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/877e2ab661da959e844d0f0f1e71f815d32d8c77
Cr-Commit-Position: refs/heads/master@{#294852}

Powered by Google App Engine
This is Rietveld 408576698