Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2101)

Unified Diff: athena/activity/public/activity_factory.h

Issue 571643003: Remove app_shell chrome.shell API and ShellAppWindow (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: (remove-shell) rebase 2 Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | athena/content/chrome/content_activity_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: athena/activity/public/activity_factory.h
diff --git a/athena/activity/public/activity_factory.h b/athena/activity/public/activity_factory.h
index e69ee7a65683eac8d9e03ebbe5088bf19da62fff..d38e31da56f9f277cfe67a9e04fbc67730f8b4d9 100644
--- a/athena/activity/public/activity_factory.h
+++ b/athena/activity/public/activity_factory.h
@@ -14,7 +14,6 @@ class BrowserContext;
namespace extensions {
class AppWindow;
-class ShellAppWindow;
}
namespace views {
@@ -43,13 +42,6 @@ class ATHENA_EXPORT ActivityFactory {
const base::string16& title,
const GURL& url) = 0;
- // Create an activity of an app with |app_window| for app shell environemnt.
- // The returned activity should own |app_window|.
- // TODO(oshima): Consolidate these two methods to create AppActivity
- // once crbug.com/403726 is finished.
- virtual Activity* CreateAppActivity(extensions::ShellAppWindow* app_window,
- const std::string& id) = 0;
-
// Create an activity of an app with |app_window| for chrome environment and
// |web_view| that will host the content.
virtual Activity* CreateAppActivity(extensions::AppWindow* app_window,
« no previous file with comments | « no previous file | athena/content/chrome/content_activity_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698