Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: extensions/shell/browser/desktop_controller.h

Issue 571643003: Remove app_shell chrome.shell API and ShellAppWindow (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: (remove-shell) rebase 2 Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/shell/browser/api/shell/shell_api.cc ('k') | extensions/shell/browser/shell_app_window.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/shell/browser/desktop_controller.h
diff --git a/extensions/shell/browser/desktop_controller.h b/extensions/shell/browser/desktop_controller.h
index 14d541f9e3cf24239ab554bb983ad6f4a9632d7b..116d692a6cb6b35f9e4674576d17f685b9f1d505 100644
--- a/extensions/shell/browser/desktop_controller.h
+++ b/extensions/shell/browser/desktop_controller.h
@@ -21,8 +21,9 @@ class ShellAppWindow;
// DesktopController is an interface to construct the window environment in
// extensions shell. ShellDesktopController provides a default implementation
-// for
-// app_shell, and embedder (such as athena) can provide its own.
+// for app_shell, and embedder (such as athena) can provide its own.
+// TODO(jamescook|oshima): Clean up this interface now that there is only one
+// way to create an app window.
class DesktopController {
public:
DesktopController();
@@ -36,12 +37,6 @@ class DesktopController {
// Returns the WindowTreeHost created by this DesktopController.
virtual aura::WindowTreeHost* GetHost() = 0;
- // Creates a new ShellAppWindow and adds it to the desktop. The desktop
- // maintains ownership of the window. The window must be closed before
- // |extension| is destroyed.
- virtual ShellAppWindow* CreateShellAppWindow(content::BrowserContext* context,
- const Extension* extension) = 0;
-
// Creates a new app window and adds it to the desktop. The desktop maintains
// ownership of the window. The window must be closed before |extension| is
// destroyed.
@@ -55,6 +50,6 @@ class DesktopController {
virtual void CloseAppWindows() = 0;
};
-} // namespace extensinos
+} // namespace extensions
#endif // EXTENSIONS_SHELL_BROWSER_DESKTOP_CONTROLLER_H_
« no previous file with comments | « extensions/shell/browser/api/shell/shell_api.cc ('k') | extensions/shell/browser/shell_app_window.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698