athena/content/shell/content_activity_factory.cc - Issue 571643003: Remove app_shell chrome.shell API and ShellAppWindow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: athena/content/shell/content_activity_factory.cc

Issue 571643003: Remove app_shell chrome.shell API and ShellAppWindow (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: (remove-shell) rebase 2 Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: athena/content/shell/content_activity_factory.cc

diff --git a/athena/content/shell/content_activity_factory.cc b/athena/content/shell/content_activity_factory.cc

index edcc76f74c41af0c22acf0e92d5293962a56901a..76ee1146bb880aeb3ecf5a205dfe7404be5afa38 100644

--- a/athena/content/shell/content_activity_factory.cc

+++ b/athena/content/shell/content_activity_factory.cc

@@ -9,12 +9,6 @@

namespace athena {

Activity* ContentActivityFactory::CreateAppActivity(

- extensions::ShellAppWindow* app_window,

- const std::string& app_id) {

- return new ShellAppActivity(app_window, app_id);

-Activity* ContentActivityFactory::CreateAppActivity(

extensions::AppWindow* app_window,

views::WebView* web_view) {

return new ShellAppActivity(app_window);

« no previous file with comments | « athena/content/shell/DEPS ('k') | athena/content/shell/shell_app_activity.h » ('j') | no next file with comments »