Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: athena/content/shell/shell_app_activity.cc

Issue 571643003: Remove app_shell chrome.shell API and ShellAppWindow (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: (remove-shell) rebase 2 Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « athena/content/shell/shell_app_activity.h ('k') | athena/main/athena_main.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: athena/content/shell/shell_app_activity.cc
diff --git a/athena/content/shell/shell_app_activity.cc b/athena/content/shell/shell_app_activity.cc
index 50eb45b6e4804f855aea7a9ef45ad9f1f8c570b7..cb008e0003621f5079eceace6429b6e8c3ba431d 100644
--- a/athena/content/shell/shell_app_activity.cc
+++ b/athena/content/shell/shell_app_activity.cc
@@ -7,23 +7,17 @@
#include "content/public/browser/web_contents.h"
#include "extensions/browser/app_window/app_window.h"
#include "extensions/browser/app_window/native_app_window.h"
-#include "extensions/shell/browser/shell_app_window.h"
#include "ui/views/controls/webview/webview.h"
namespace athena {
ShellAppActivity::ShellAppActivity(extensions::AppWindow* app_window)
: AppActivity(app_window->extension_id()), app_window_(app_window) {
-}
-
-ShellAppActivity::ShellAppActivity(extensions::ShellAppWindow* app_window,
- const std::string& app_id)
- : AppActivity(app_id), app_window_(NULL), shell_app_window_(app_window) {
+ DCHECK(app_window_);
}
ShellAppActivity::~ShellAppActivity() {
- if (app_window_)
- app_window_->GetBaseWindow()->Close(); // Deletes |app_window_|.
+ app_window_->GetBaseWindow()->Close(); // Deletes |app_window_|.
}
views::Widget* ShellAppActivity::CreateWidget() {
@@ -31,9 +25,7 @@ views::Widget* ShellAppActivity::CreateWidget() {
}
views::WebView* ShellAppActivity::GetWebView() {
- content::WebContents* web_contents =
- app_window_ ? app_window_->web_contents() :
- shell_app_window_->GetAssociatedWebContents();
+ content::WebContents* web_contents = app_window_->web_contents();
views::WebView* web_view =
new views::WebView(web_contents->GetBrowserContext());
web_view->SetWebContents(web_contents);
« no previous file with comments | « athena/content/shell/shell_app_activity.h ('k') | athena/main/athena_main.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698