chrome/common/extensions/docs/examples/apps/calculator/app/controller.js - Issue 571643003: Remove app_shell chrome.shell API and ShellAppWindow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/examples/apps/calculator/app/controller.js

Issue 571643003: Remove app_shell chrome.shell API and ShellAppWindow (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: (remove-shell) rebase 2 Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/extensions/docs/examples/apps/calculator/app/controller.js

diff --git a/chrome/common/extensions/docs/examples/apps/calculator/app/controller.js b/chrome/common/extensions/docs/examples/apps/calculator/app/controller.js

index 05745bd6ebf1f534b6a14e383b609768e389b841..18a13e975fd0ecae26c8b55346ac1c8c6e5605ed 100644

--- a/chrome/common/extensions/docs/examples/apps/calculator/app/controller.js

+++ b/chrome/common/extensions/docs/examples/apps/calculator/app/controller.js

@@ -12,12 +12,8 @@

// Checking for "chrome.app.runtime" availability allows testing in a regular

// web page (like tests/manual.html).

if (typeof chrome !== 'undefined' && chrome.app && chrome.app.runtime) {

- // Compatibility for running under app_shell, which does not have app.window.

- var createWindow =

- chrome.shell ? chrome.shell.createWindow : chrome.app.window.create;

var showCalculatorWindow = function () {

- createWindow('calculator.html', {

+ chrome.app.window.create('calculator.html', {

innerBounds: {

width: 243, minWidth: 243, maxWidth: 243,

height: 380, minHeight: 380, maxHeight: 380

« no previous file with comments | « athena/test/sample_activity_factory.cc ('k') | extensions/BUILD.gn » ('j') | no next file with comments »