Fix WeakPtrFactory member ordering in chrome/browser/safe_browsing

Fix WeakPtrFactory member ordering in chrome/browser/safe_browsing

Changing in the intialization order of WeakPtrFactory such that all
member variables should appear before the WeakPtrFactory to ensure
that any WeakPtrs to Controller are invalidated before its members
variable's destructors are executed, rendering them invalid.

BUG=303818
Committed: https://crrev.com/ee619053c02ead7375c1626d4de9870ddb330614
Cr-Commit-Position: refs/heads/master@{#295240}

[MRV, 2014-09-16 03:01:44]

mohan.reddy@samsung.com changed reviewers:
+ mattm@chromium.org

[MRV, 2014-09-16 03:01:44]

PTAL

[mattm, 2014-09-16 20:27:14]

CL summary line could be worded more clearly. Something like
"Fix WeakPtrFactory member ordering in chrome/browser/safe_browsing"

[MRV, 2014-09-17 02:07:13]

On 2014/09/16 20:27:14, mattm wrote:
> CL summary line could be worded more clearly. Something like
> "Fix WeakPtrFactory member ordering in chrome/browser/safe_browsing"

Hi mr.matt, Thanks for comment, I have updated my heading accordingly.
PTAL.

[mattm, 2014-09-17 02:33:42]

lgtm

[MRV, 2014-09-17 02:44:47]

On 2014/09/17 02:33:42, mattm wrote:
> lgtm

Thanks Mr. Mattm for LGTM

[MRV, 2014-09-17 02:44:51]

The CQ bit was checked by mohan.reddy@samsung.com

[commit-bot: I haz the power, 2014-09-17 02:46:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/570713007/1

[commit-bot: I haz the power, 2014-09-17 04:46:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-17 04:46:47]

Exceeded time limit waiting for builds to trigger.

[MRV, 2014-09-17 04:47:26]

The CQ bit was checked by mohan.reddy@samsung.com

[commit-bot: I haz the power, 2014-09-17 04:47:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/570713007/1

[commit-bot: I haz the power, 2014-09-17 06:48:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-17 06:48:27]

Exceeded time limit waiting for builds to trigger.

[MRV, 2014-09-17 06:55:28]

The CQ bit was checked by mohan.reddy@samsung.com

[commit-bot: I haz the power, 2014-09-17 06:55:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/570713007/1

[commit-bot: I haz the power, 2014-09-17 08:03:16]

Committed patchset #1 (id:1) as 98414d02d90e90c5a9f7f1915f30ca23242facdf

[commit-bot: I haz the power, 2014-09-17 08:03:47]

Patchset 1 (id:??) landed as
https://crrev.com/ee619053c02ead7375c1626d4de9870ddb330614
Cr-Commit-Position: refs/heads/master@{#295240}