chrome/browser/safe_browsing/client_side_detection_service.cc - Issue 570713007: Fix WeakPtrFactory member ordering in chrome/browser/safe_browsing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/client_side_detection_service.cc

Issue 570713007: Fix WeakPtrFactory member ordering in chrome/browser/safe_browsing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/client_side_detection_service.h ('k') | chrome/browser/safe_browsing/safe_browsing_database.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/client_side_detection_service.cc

diff --git a/chrome/browser/safe_browsing/client_side_detection_service.cc b/chrome/browser/safe_browsing/client_side_detection_service.cc

index ffdfad1a4924a7d504e1cdc5b4fd0aeed7f14576..41e4ecc838cd1d497486bc57d2bca460e8cc1c97 100644

--- a/chrome/browser/safe_browsing/client_side_detection_service.cc

+++ b/chrome/browser/safe_browsing/client_side_detection_service.cc

@@ -100,8 +100,8 @@ ClientSideDetectionService::CacheState::CacheState(bool phish, base::Time time)

ClientSideDetectionService::ClientSideDetectionService(

net::URLRequestContextGetter* request_context_getter)

: enabled_(false),

- weak_factory_(this),

- request_context_getter_(request_context_getter) {

+ request_context_getter_(request_context_getter),

+ weak_factory_(this) {

registrar_.Add(this, content::NOTIFICATION_RENDERER_PROCESS_CREATED,

content::NotificationService::AllBrowserContextsAndSources());

}