Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Side by Side Diff: chrome/browser/safe_browsing/client_side_detection_host.h

Issue 570713007: Fix WeakPtrFactory member ordering in chrome/browser/safe_browsing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/client_side_detection_host.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SAFE_BROWSING_CLIENT_SIDE_DETECTION_HOST_H_ 5 #ifndef CHROME_BROWSER_SAFE_BROWSING_CLIENT_SIDE_DETECTION_HOST_H_
6 #define CHROME_BROWSER_SAFE_BROWSING_CLIENT_SIDE_DETECTION_HOST_H_ 6 #define CHROME_BROWSER_SAFE_BROWSING_CLIENT_SIDE_DETECTION_HOST_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 154 matching lines...) Expand 10 before | Expand all | Expand 10 after
165 165
166 // Max number of ips we save for each browse 166 // Max number of ips we save for each browse
167 static const size_t kMaxIPsPerBrowse; 167 static const size_t kMaxIPsPerBrowse;
168 // Max number of urls we report for each malware IP. 168 // Max number of urls we report for each malware IP.
169 static const size_t kMaxUrlsPerIP; 169 static const size_t kMaxUrlsPerIP;
170 170
171 bool should_extract_malware_features_; 171 bool should_extract_malware_features_;
172 bool should_classify_for_malware_; 172 bool should_classify_for_malware_;
173 bool pageload_complete_; 173 bool pageload_complete_;
174 174
175 base::WeakPtrFactory<ClientSideDetectionHost> weak_factory_;
176
177 // Unique page ID of the most recent unsafe site that was loaded in this tab 175 // Unique page ID of the most recent unsafe site that was loaded in this tab
178 // as well as the UnsafeResource. 176 // as well as the UnsafeResource.
179 int unsafe_unique_page_id_; 177 int unsafe_unique_page_id_;
180 scoped_ptr<SafeBrowsingUIManager::UnsafeResource> unsafe_resource_; 178 scoped_ptr<SafeBrowsingUIManager::UnsafeResource> unsafe_resource_;
181 179
180 base::WeakPtrFactory<ClientSideDetectionHost> weak_factory_;
181
182 DISALLOW_COPY_AND_ASSIGN(ClientSideDetectionHost); 182 DISALLOW_COPY_AND_ASSIGN(ClientSideDetectionHost);
183 }; 183 };
184 184
185 } // namespace safe_browsing 185 } // namespace safe_browsing
186 186
187 #endif // CHROME_BROWSER_SAFE_BROWSING_CLIENT_SIDE_DETECTION_HOST_H_ 187 #endif // CHROME_BROWSER_SAFE_BROWSING_CLIENT_SIDE_DETECTION_HOST_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/client_side_detection_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698