Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1495)

Unified Diff: chrome/browser/safe_browsing/client_side_detection_service.h

Issue 570713007: Fix WeakPtrFactory member ordering in chrome/browser/safe_browsing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/client_side_detection_service.h
diff --git a/chrome/browser/safe_browsing/client_side_detection_service.h b/chrome/browser/safe_browsing/client_side_detection_service.h
index ed44a431b9eeb4eca68de4b8c3f0905dac4df3f9..f7a0d0ad933c4c2c1e571f98192f49e0d5371c6a 100644
--- a/chrome/browser/safe_browsing/client_side_detection_service.h
+++ b/chrome/browser/safe_browsing/client_side_detection_service.h
@@ -316,10 +316,6 @@ class ClientSideDetectionService : public net::URLFetcherDelegate,
// of malware requests that we send in a day.
std::queue<base::Time> malware_report_times_;
- // Used to asynchronously call the callbacks for
- // SendClientReportPhishingRequest.
- base::WeakPtrFactory<ClientSideDetectionService> weak_factory_;
-
// The context we use to issue network requests.
scoped_refptr<net::URLRequestContextGetter> request_context_getter_;
@@ -329,6 +325,10 @@ class ClientSideDetectionService : public net::URLFetcherDelegate,
content::NotificationRegistrar registrar_;
+ // Used to asynchronously call the callbacks for
+ // SendClientReportPhishingRequest.
+ base::WeakPtrFactory<ClientSideDetectionService> weak_factory_;
+
DISALLOW_COPY_AND_ASSIGN(ClientSideDetectionService);
};
} // namespace safe_browsing

Powered by Google App Engine
This is Rietveld 408576698