Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_database.h

Issue 570713007: Fix WeakPtrFactory member ordering in chrome/browser/safe_browsing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_database.h
diff --git a/chrome/browser/safe_browsing/safe_browsing_database.h b/chrome/browser/safe_browsing/safe_browsing_database.h
index 09b22aad278ca106371391540a2e262d1f231faa..32fad8a4d9530f42a5e04adbafdf1a445a76276e 100644
--- a/chrome/browser/safe_browsing/safe_browsing_database.h
+++ b/chrome/browser/safe_browsing/safe_browsing_database.h
@@ -456,9 +456,6 @@ class SafeBrowsingDatabaseNew : public SafeBrowsingDatabase {
// empty full_hashes field. Cleared on each update.
std::map<SBPrefix, SBCachedFullHashResult> browse_gethash_cache_;
- // Used to schedule resetting the database because of corruption.
- base::WeakPtrFactory<SafeBrowsingDatabaseNew> reset_factory_;
-
// Set if corruption is detected during the course of an update.
// Causes the update functions to fail with no side effects, until
// the next call to |UpdateStarted()|.
@@ -473,6 +470,9 @@ class SafeBrowsingDatabaseNew : public SafeBrowsingDatabase {
// Used to check if a prefix was in the browse database.
scoped_ptr<safe_browsing::PrefixSet> side_effect_free_whitelist_prefix_set_;
+
+ // Used to schedule resetting the database because of corruption.
+ base::WeakPtrFactory<SafeBrowsingDatabaseNew> reset_factory_;
};
#endif // CHROME_BROWSER_SAFE_BROWSING_SAFE_BROWSING_DATABASE_H_
« no previous file with comments | « chrome/browser/safe_browsing/client_side_detection_service.cc ('k') | chrome/browser/safe_browsing/safe_browsing_database.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698