chrome/browser/safe_browsing/client_side_detection_host.cc - Issue 570713007: Fix WeakPtrFactory member ordering in chrome/browser/safe_browsing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/client_side_detection_host.cc

Issue 570713007: Fix WeakPtrFactory member ordering in chrome/browser/safe_browsing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/client_side_detection_host.h ('k') | chrome/browser/safe_browsing/client_side_detection_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/client_side_detection_host.cc

diff --git a/chrome/browser/safe_browsing/client_side_detection_host.cc b/chrome/browser/safe_browsing/client_side_detection_host.cc

index 89a4196e01e081ae4a2047313cf0a60c78d2ea2d..1ca33a59c3be9823874e039f2f180e424317f51d 100644

--- a/chrome/browser/safe_browsing/client_side_detection_host.cc

+++ b/chrome/browser/safe_browsing/client_side_detection_host.cc

@@ -323,8 +323,8 @@ ClientSideDetectionHost::ClientSideDetectionHost(WebContents* tab)

should_extract_malware_features_(true),

should_classify_for_malware_(false),

pageload_complete_(false),

- weak_factory_(this),

- unsafe_unique_page_id_(-1) {

+ unsafe_unique_page_id_(-1),

+ weak_factory_(this) {

DCHECK(tab);

// Note: csd_service_ and sb_service will be NULL here in testing.

csd_service_ = g_browser_process->safe_browsing_detection_service();