Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 569493003: Remove CreateEmptyExtension from extension_function_test_utils (Closed)

Created:
6 years, 3 months ago by limasdf
Modified:
6 years, 3 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, dkrahn+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove CreateEmptyExtension from extension_function_test_utils because "extensions/common/test_util.h" has duplicate function. BUG=394840 Committed: https://crrev.com/f0dcf2f802455adebc73eca469d222d18e5560f9 Cr-Commit-Position: refs/heads/master@{#295541}

Patch Set 1 #

Total comments: 3

Patch Set 2 : remove crx_generateId and cleanup #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -122 lines) Patch
M chrome/browser/extensions/api/browser/browser_apitest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/identity/identity_apitest.cc View 1 12 chunks +15 lines, -23 lines 0 comments Download
M chrome/browser/extensions/api/management/management_api_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/notifications/notifications_apitest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_apitest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/system_network/system_network_apitest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_interactive_test.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_test.cc View 15 chunks +15 lines, -14 lines 0 comments Download
M chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_apitest.cc View 4 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_function_test_utils.h View 1 chunk +0 lines, -13 lines 0 comments Download
M chrome/browser/extensions/extension_function_test_utils.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M extensions/browser/api/api_resource_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/api/bluetooth/bluetooth_apitest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc View 6 chunks +2 lines, -6 lines 0 comments Download
M extensions/browser/api/bluetooth_socket/bluetooth_socket_apitest.cc View 4 chunks +2 lines, -3 lines 0 comments Download
M extensions/browser/api/cast_channel/cast_channel_apitest.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M extensions/browser/api/power/power_api_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/extension_registry_unittest.cc View 5 chunks +11 lines, -12 lines 0 comments Download
M extensions/browser/runtime_data_unittest.cc View 4 chunks +4 lines, -12 lines 0 comments Download
M extensions/common/test_util.h View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M extensions/common/test_util.cc View 1 2 1 chunk +5 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
limasdf
PTAL!
6 years, 3 months ago (2014-09-14 15:17:59 UTC) #2
Yoyo Zhou
https://chromiumcodereview.appspot.com/569493003/diff/1/chrome/browser/extensions/api/identity/identity_apitest.cc File chrome/browser/extensions/api/identity/identity_apitest.cc (right): https://chromiumcodereview.appspot.com/569493003/diff/1/chrome/browser/extensions/api/identity/identity_apitest.cc#newcode1599 chrome/browser/extensions/api/identity/identity_apitest.cc:1599: crx_file::id_util::GenerateId(kExtensionId)).get()); Why is this changed?
6 years, 3 months ago (2014-09-15 18:52:43 UTC) #3
limasdf
PTAL! https://codereview.chromium.org/569493003/diff/1/chrome/browser/extensions/api/identity/identity_apitest.cc File chrome/browser/extensions/api/identity/identity_apitest.cc (right): https://codereview.chromium.org/569493003/diff/1/chrome/browser/extensions/api/identity/identity_apitest.cc#newcode1599 chrome/browser/extensions/api/identity/identity_apitest.cc:1599: crx_file::id_util::GenerateId(kExtensionId)).get()); On 2014/09/15 18:52:43, Yoyo Zhou wrote: > ...
6 years, 3 months ago (2014-09-16 15:36:47 UTC) #4
Yoyo Zhou
LGTM https://codereview.chromium.org/569493003/diff/1/chrome/browser/extensions/api/identity/identity_apitest.cc File chrome/browser/extensions/api/identity/identity_apitest.cc (right): https://codereview.chromium.org/569493003/diff/1/chrome/browser/extensions/api/identity/identity_apitest.cc#newcode1599 chrome/browser/extensions/api/identity/identity_apitest.cc:1599: crx_file::id_util::GenerateId(kExtensionId)).get()); On 2014/09/16 15:36:47, limasdf wrote: > On ...
6 years, 3 months ago (2014-09-18 17:55:29 UTC) #5
limasdf
On 2014/09/18 17:55:29, Yoyo Zhou wrote: > LGTM > > https://codereview.chromium.org/569493003/diff/1/chrome/browser/extensions/api/identity/identity_apitest.cc > File chrome/browser/extensions/api/identity/identity_apitest.cc (right): ...
6 years, 3 months ago (2014-09-18 17:57:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/569493003/20001
6 years, 3 months ago (2014-09-18 17:57:25 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/57768) android_chromium_gn_compile_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/300) ios_dbg_simulator ...
6 years, 3 months ago (2014-09-18 18:01:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/569493003/40001
6 years, 3 months ago (2014-09-18 18:59:52 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 300517b05a36dcb43138683c1c852f525e895f31
6 years, 3 months ago (2014-09-18 20:17:45 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 20:18:15 UTC) #14
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/f0dcf2f802455adebc73eca469d222d18e5560f9
Cr-Commit-Position: refs/heads/master@{#295541}

Powered by Google App Engine
This is Rietveld 408576698