chrome/browser/extensions/api/tabs/tabs_interactive_test.cc - Issue 569493003: Remove CreateEmptyExtension from extension_function_test_utils

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/tabs/tabs_interactive_test.cc

Issue 569493003: Remove CreateEmptyExtension from extension_function_test_utils (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/system_network/system_network_apitest.cc ('k') | chrome/browser/extensions/api/tabs/tabs_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/tabs/tabs_interactive_test.cc

diff --git a/chrome/browser/extensions/api/tabs/tabs_interactive_test.cc b/chrome/browser/extensions/api/tabs/tabs_interactive_test.cc

index 30564addc3e7dad6c36a9fa3e70f57809219cab9..674ffbd696ed200f4c5993b27e2e8c8c979caee4 100644

--- a/chrome/browser/extensions/api/tabs/tabs_interactive_test.cc

+++ b/chrome/browser/extensions/api/tabs/tabs_interactive_test.cc

@@ -13,6 +13,7 @@

#include "chrome/test/base/in_process_browser_test.h"

#include "chrome/test/base/interactive_test_utils.h"

#include "chrome/test/base/ui_test_utils.h"

+#include "extensions/common/test_util.h"

namespace keys = extensions::tabs_constants;

namespace utils = extension_function_test_utils;

@@ -36,7 +37,8 @@ IN_PROC_BROWSER_TEST_F(ExtensionTabsTest, MAYBE_GetLastFocusedWindow) {

scoped_refptr<extensions::WindowsGetLastFocusedFunction> function =

new extensions::WindowsGetLastFocusedFunction();

- scoped_refptr<extensions::Extension> extension(utils::CreateEmptyExtension());

+ scoped_refptr<extensions::Extension> extension(

+ extensions::test_util::CreateEmptyExtension());

function->set_extension(extension.get());

scoped_ptr<base::DictionaryValue> result(utils::ToDictionary(

utils::RunFunctionAndReturnSingleResult(function.get(),