Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Unified Diff: extensions/common/test_util.cc

Issue 569493003: Remove CreateEmptyExtension from extension_function_test_utils (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/test_util.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/test_util.cc
diff --git a/extensions/common/test_util.cc b/extensions/common/test_util.cc
index 4eacfa68f3e91c94e53f6654f3b8b1192efba73d..e7efeb02a2704c43756d84661907a661f41ec17b 100644
--- a/extensions/common/test_util.cc
+++ b/extensions/common/test_util.cc
@@ -20,15 +20,13 @@ ExtensionBuilder& BuildExtension(ExtensionBuilder& builder) {
}
scoped_refptr<Extension> CreateEmptyExtension() {
- scoped_refptr<Extension> empty_extension(
- ExtensionBuilder()
- .SetManifest(
- DictionaryBuilder().Set("name", "Test").Set("version", "1.0"))
- .Build());
- return empty_extension;
+ return ExtensionBuilder()
+ .SetManifest(
+ DictionaryBuilder().Set("name", "Test").Set("version", "1.0"))
+ .Build();
}
-scoped_refptr<Extension> CreateExtensionWithID(const std::string& id) {
+scoped_refptr<Extension> CreateEmptyExtension(const std::string& id) {
return ExtensionBuilder()
.SetManifest(
DictionaryBuilder().Set("name", "test").Set("version", "0.1"))
« no previous file with comments | « extensions/common/test_util.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698