chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_apitest.cc - Issue 569493003: Remove CreateEmptyExtension from extension_function_test_utils

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_apitest.cc

Issue 569493003: Remove CreateEmptyExtension from extension_function_test_utils (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/notifications/notifications_apitest.cc ('k') | chrome/browser/extensions/api/system_network/system_network_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_apitest.cc

diff --git a/chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_apitest.cc b/chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_apitest.cc

index e74eed8b0effd448feb496eaa92f6146a31f94d6..99148b3e749862675ec90b062e33618c29930af3 100644

--- a/chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_apitest.cc

+++ b/chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_apitest.cc

@@ -17,6 +17,7 @@

#include "extensions/browser/api/dns/host_resolver_wrapper.h"

#include "extensions/browser/api/dns/mock_host_resolver_creator.h"

#include "extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.h"

+#include "extensions/common/test_util.h"

#include "extensions/test/result_catcher.h"

#include "net/dns/mock_host_resolver.h"

#include "net/test/spawned_test_server/spawned_test_server.h"

@@ -70,7 +71,8 @@ class SocketsTcpServerApiTest : public ExtensionApiTest {

IN_PROC_BROWSER_TEST_F(SocketsTcpServerApiTest, SocketTCPCreateGood) {

scoped_refptr<SocketsTcpServerCreateFunction>

socket_create_function(new SocketsTcpServerCreateFunction());

- scoped_refptr<Extension> empty_extension(utils::CreateEmptyExtension());

+ scoped_refptr<Extension> empty_extension(

+ extensions::test_util::CreateEmptyExtension());

socket_create_function->set_extension(empty_extension.get());

socket_create_function->set_has_callback(true);