extensions/browser/api/cast_channel/cast_channel_apitest.cc - Issue 569493003: Remove CreateEmptyExtension from extension_function_test_utils

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/cast_channel/cast_channel_apitest.cc

Issue 569493003: Remove CreateEmptyExtension from extension_function_test_utils (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/bluetooth_socket/bluetooth_socket_apitest.cc ('k') | extensions/browser/api/power/power_api_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/cast_channel/cast_channel_apitest.cc

diff --git a/extensions/browser/api/cast_channel/cast_channel_apitest.cc b/extensions/browser/api/cast_channel/cast_channel_apitest.cc

index 289c71e6c6a06d9efb9f3bde713ed441b69d57aa..065de56f06fd429ae34b03c92e97af7dfebb30f9 100644

--- a/extensions/browser/api/cast_channel/cast_channel_apitest.cc

+++ b/extensions/browser/api/cast_channel/cast_channel_apitest.cc

@@ -15,6 +15,7 @@

#include "extensions/browser/api/cast_channel/logger.h"

#include "extensions/common/api/cast_channel.h"

#include "extensions/common/switches.h"

+#include "extensions/common/test_util.h"

#include "extensions/test/result_catcher.h"

#include "net/base/capturing_net_log.h"

#include "net/base/completion_callback.h"

@@ -294,7 +295,8 @@ IN_PROC_BROWSER_TEST_F(CastChannelAPITest, MAYBE_TestOpenError) {

}

IN_PROC_BROWSER_TEST_F(CastChannelAPITest, TestOpenInvalidConnectInfo) {

- scoped_refptr<Extension> empty_extension(utils::CreateEmptyExtension());

+ scoped_refptr<Extension> empty_extension =

+ extensions::test_util::CreateEmptyExtension();

scoped_refptr<extensions::CastChannelOpenFunction> cast_channel_open_function;

// Invalid URL

@@ -338,7 +340,8 @@ IN_PROC_BROWSER_TEST_F(CastChannelAPITest, TestOpenInvalidConnectInfo) {

}

IN_PROC_BROWSER_TEST_F(CastChannelAPITest, TestSendInvalidMessageInfo) {

- scoped_refptr<Extension> empty_extension(utils::CreateEmptyExtension());

+ scoped_refptr<Extension> empty_extension(

+ extensions::test_util::CreateEmptyExtension());

scoped_refptr<extensions::CastChannelSendFunction> cast_channel_send_function;

// Numbers are not supported