chrome/browser/extensions/api/browser/browser_apitest.cc - Issue 569493003: Remove CreateEmptyExtension from extension_function_test_utils

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/browser/browser_apitest.cc

Issue 569493003: Remove CreateEmptyExtension from extension_function_test_utils (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/browser/browser_apitest.cc

diff --git a/chrome/browser/extensions/api/browser/browser_apitest.cc b/chrome/browser/extensions/api/browser/browser_apitest.cc

index 88754b839bfd4a27f8f447e9f89e0a3634457765..eae51aa3f476d692ff06f164a0a275111354d650 100644

--- a/chrome/browser/extensions/api/browser/browser_apitest.cc

+++ b/chrome/browser/extensions/api/browser/browser_apitest.cc

@@ -10,6 +10,7 @@

#include "chrome/browser/extensions/api/browser/browser_api.h"

#include "chrome/browser/extensions/extension_function_test_utils.h"

#include "chrome/test/base/in_process_browser_test.h"

+#include "extensions/common/test_util.h"

namespace extensions {

@@ -27,7 +28,7 @@ IN_PROC_BROWSER_TEST_F(BrowserApiTest, OpenTab) {

scoped_refptr<api::BrowserOpenTabFunction> function =

new api::BrowserOpenTabFunction();

- scoped_refptr<Extension> extension(utils::CreateEmptyExtension());

+ scoped_refptr<Extension> extension(test_util::CreateEmptyExtension());

function->set_extension(extension.get());

base::Value* result = utils::RunFunctionAndReturnSingleResult(

function.get(),