Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 558283004: bindings: Pass IDL dictionary references instead of pointers (Closed)

Created:
6 years, 3 months ago by bashi
Modified:
6 years, 3 months ago
Reviewers:
haraken, tkent
CC:
blink-reviews, arv+blink, blink-reviews-css, eae+blinkwatch, ed+blinkwatch_opera.com, abarth-chromium, blink-reviews-events_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, darktears, apavlov+blink_chromium.org, rwlbuis, rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@dic-webmidi
Project:
blink
Visibility:
Public.

Description

bindings: Pass IDL dictionary references instead of pointers It will be less error-prone to pass references instead of pointers. Customers don't need to add ASSERT(). This is a follow-up CL of https://codereview.chromium.org/547383004/, and no changes in behavior. BUG=321462 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181871

Patch Set 1 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -55 lines) Patch
M Source/bindings/scripts/v8_methods.py View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/FontFace.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/FontFace.cpp View 3 chunks +9 lines, -9 lines 0 comments Download
M Source/core/page/EventSource.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/page/EventSource.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/testing/DictionaryTest.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/DictionaryTest.cpp View 1 chunk +25 lines, -25 lines 0 comments Download
M Source/modules/webmidi/MIDIAccessInitializer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/webmidi/MIDIAccessInitializer.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M Source/modules/webmidi/NavigatorWebMIDI.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webmidi/NavigatorWebMIDI.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
bashi
Haraken-san, PTAL? (Kent-san, FYI)
6 years, 3 months ago (2014-09-12 02:04:59 UTC) #3
haraken
LGTM
6 years, 3 months ago (2014-09-12 02:06:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/558283004/20001
6 years, 3 months ago (2014-09-12 02:10:28 UTC) #6
tkent
thanks!
6 years, 3 months ago (2014-09-12 02:19:10 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 02:36:54 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as 181871

Powered by Google App Engine
This is Rietveld 408576698